Integrating types to make this work with TypeScript about js-libp2p-gossipsub HOT 8 CLOSED

Whats the status on this? Should we wait until we chat with the libp2p2 team?

from js-libp2p-gossipsub.

I think we should wait until the chat with the libp2p team. I will contact Raul again to see what their availability is on their end.

from js-libp2p-gossipsub.

During the call, there were several ideas about how to go about this. For now, we will be making bindings for gossipsub and potentially in the future, make them for libp2p.

from js-libp2p-gossipsub.

The issue was that as soon as you begin typing a module, you realise that that module likely uses classes or objects from another module (e.g. switch, connection manager, etc.), which ideally would be typed as well.

To avoid galavanting around all of libp2p typing everything at once, you can either use any, object, or type the element locally with only the methods and properties you are using from within gossipsub.

EDIT: As you eventually make your way around the codebase, the types you define at the origin sites will be supersets of the local types at call site, so they can easily subsume those without causing breakage.

from js-libp2p-gossipsub.

^^ let me know if you need an example of the above. Feels kinda abstract.

from js-libp2p-gossipsub.

If we type the element using any or object, I think that defeats the purpose of using types and we don't get the "built-in" documentation that using TypeScript provides. By locally typing elements, do you mean something like this?

from js-libp2p-gossipsub.

That's an interesting approach that's enabled by typeRoots. That could definitely work -- and in fact we can go over those types at the Polkadot repo and revise them in order to, eventually, add them to the corresponding repos at libp2p.

What I had in mind was something like this. Imagine an index.d.ts file in this repo's root (names are all made up examples):

declare module 'js-libp2p-switch' {
   interface libp2pswitch {
     // lazily declare only the methods and fields you use.
     methodA(): typeA;
     methodB(): typeB;
     readonly fieldC: typeC;
   }
}

class GossipSub {
  static public readonly switch: libp2pswitch;
  subscribe(topic: string): Result;
}

But yeah, I agree that placing the ambient declarations for each imported module in a file of its own, and linking it via typeRoots is probably cleaner and better scoped.

On a related note, let's try and converge our types with Polkadot's!

from js-libp2p-gossipsub.

Closing since its stale

from js-libp2p-gossipsub.