Shell.Interactive should not run availableTestCommands about libsuperuser HOT 3 CLOSED

While you are absolutely correct that the availableTestCommands are run at the wrong time (and I'll commit the fix for that when we're done talking here) if commands are added to the builder, the title of this issue makes me wonder what exactly you are after.

The title states that availableTestCommands should not be run at all. What makes you say that? The idea for attaching an OnCommandResultListener to the open call is getting a callback telling you if the shell was opened correctly or not. If you are looking to get the exitCode and output of the commands you're executing, you should attach an OnCommandResultListener to the addCommand call instead of the open call.

Please clarify.

from libsuperuser.

You are correct. The title was misleading. It was a late night. :)

from libsuperuser.

Thanks for the quick fix. I see it would be best to add the OnCommandResultListener to the addCommand call. Something you might want to consider though is not sending onLine results for availableTestCommands as that is something the caller would not be expecting.

from libsuperuser.