Make learning mocks print immediately about cgreen HOT 4 OPEN

Yes, learning mocks was one of the "revolutionary" features that brought me to Cgreen in the first place.

from cgreen.

This was actually on purpose in the original intent: In legacy code bases, there may be gobs of console output and we didn't want the learning mocks output interspersed with legacy console cruft. When in learning mode, I thought that mocks wouldn't error at all?

from cgreen.

Hi Matt! Long time no see!

Thanks for that historical data point ;-)

The problem is not that the mocks error out, do they ever? But the code called under the test, possibly indirectly, calling the mock might break if an expected value was not returned. A typical case is that the mocked function was supposed to return a valid pointer and the calling function might crash with a NPE since the mock did not return anything, or rather the default value (null).

Yup, you could say

1. You should always check for null, but legacy code... and I think you shouldn't need to if the "contract" says "will always return valid pointer"
2. You will have to fix that return value anyway, but it is a matter of in which order we are exploring how the mock should work, return value first or arguments.

I've come across a number of cases when I did not know the code under test enough to realize that that would happen, and tried with learning mocks, but was disappointed. I'm not sure that changing as suggested in this issue would have helped though. Maybe a hidden flag so we can try both next time ;-)

But the "legacy console cruft" is a fair point.

from cgreen.

I like the configuration idea, and you could even change the default behavior from what it is now, to support both reasonable needs. Going deeper into optimizing the developer iteration loop for learning mocks is a great thing to be proactive about!

from cgreen.