Giter Club home page Giter Club logo

Comments (1)

Tachi107 avatar Tachi107 commented on June 12, 2024

After looking a bit more into this issue I noticed how DEFAULT_COMPILE_OPTIONS is simply treated as a string array that gets later passed into target_compile_options(), that indeed supports PRIVATE and PUBLIC. The issue here seems to be that Meson has some issues parsing compile options passed to target_compile_options() as a semicolon-separated list, and instead of seeing PRIVATE and PUBLIC as keywords it sees it as raw compile options.

One possible solution would be to split DEFAULT_COMPILE_OPTIONS into two variables, DEFAULT_COMPILE_OPTIONS_PRIVATE and _PUBLIC, or raising the minimum required CMake version to 3.1 so that defining PUBLIC flags in DEFAULT_COMPILE_OPTIONS will be no longer needed. (On this matter, CMake 3.5 or better is supported on all the maintained Linux distributions, and would be a safe version to require)

from glbinding.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.