Comments (2)
Comments on Sept. 16
-
Where are the modified 6j routines?
-
Technically, in GitHub, the changes should be committed, pushed, merged so that
i) Unused routines (now internal) are deleted.
ii) The top routines is changed. I will try
and get help for you on this. -
The call routines show that rcsfinteract used modified versions of the el-routines in the library. We need to find out how they are modified and then consider having an option in the el-routines to include the option. I believe the elINT routines are a subset of el. This is a typical situation. A library
routine needs a modification. Instead of modifying the library it is easier to importa library routine into an application and modify it. -
What conclusions did you arrive at from a study of the "call" analysis?
-
General comments for updated routines.
i) remove all old commented out code.
ii) Keep documentation to what the routine does and not our objectives. These apply broadly and not just one procedure. The statement you made was incomplete.
iii) Remove the statement "Subroutines Called" when there are no routines called.
iv) Keep written comments on "who did what" to the main program. Delete from internal programs unless it has different developers.
v) Use ..._I.f90 routines should be removed for calls to internal routines. -
Subroutine oneparticlejj contains oneparticlejj1(2) Note: internal routines cannot be called from other external routines. None were found for this subroutine
-
Subroutine onescalar -- general comments apply
-
Remove Gracah from librang -- it is used by some applications but is not part of rang.
-
Subroutine rkco --- eile is called only by el33 and el41 so it can be an internal routine for rkco. No interface is needed. In EL52 the statements, COND and CONE are both local arrays of Dimension(12,20) they are not initialized at the beginning, but with a DO loop later on. The DO II = 1,20 ... END DO is equivalent to COND = Zero and CONE = =Zero (much shorter) Same happens in EL53 as well.
from project-5.
sixj
The USE CONS_C, ONLY: ZERO, ONE should be checked. It is now the USE statement for the entire group, not just the top level routine. Remove the ONLY portion.
from project-5.
Related Issues (1)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from project-5.