Comments on Sept. 16

1. Where are the modified 6j routines?

2. Technically, in GitHub, the changes should be committed, pushed, merged so that
   i) Unused routines (now internal) are deleted.
   ii) The top routines is changed. I will try
   and get help for you on this.

3. The call routines show that rcsfinteract used modified versions of the el-routines in the library. We need to find out how they are modified and then consider having an option in the el-routines to include the option. I believe the elINT routines are a subset of el. This is a typical situation. A library
   routine needs a modification. Instead of modifying the library it is easier to importa library routine into an application and modify it.

4. What conclusions did you arrive at from a study of the "call" analysis?

5. General comments for updated routines.
   i) remove all old commented out code.
   ii) Keep documentation to what the routine does and not our objectives. These apply broadly and not just one procedure. The statement you made was incomplete.
   iii) Remove the statement "Subroutines Called" when there are no routines called.
   iv) Keep written comments on "who did what" to the main program. Delete from internal programs unless it has different developers.
   v) Use ..._I.f90 routines should be removed for calls to internal routines.

6. Subroutine oneparticlejj contains oneparticlejj1(2) Note: internal routines cannot be called from other external routines. None were found for this subroutine

7. Subroutine onescalar -- general comments apply

8. Remove Gracah from librang -- it is used by some applications but is not part of rang.

9. Subroutine rkco --- eile is called only by el33 and el41 so it can be an internal routine for rkco. No interface is needed. In EL52 the statements, COND and CONE are both local arrays of Dimension(12,20) they are not initialized at the beginning, but with a DO loop later on. The DO II = 1,20 ... END DO is equivalent to COND = Zero and CONE = =Zero (much shorter) Same happens in EL53 as well.

from project-5.

sixj

The USE CONS_C, ONLY: ZERO, ONE should be checked. It is now the USE statement for the entire group, not just the top level routine. Remove the ONLY portion.

from project-5.