Comments (5)
elsif2
commented on July 17, 2024
1
I believe it should be if self.types.
from intelmq.
kamil-certat
commented on July 17, 2024
Looks like it should be just if not self.types
from intelmq.
sebix
commented on July 17, 2024
Yes, that's clearly a bug
from intelmq.
elsif2
commented on July 17, 2024
All the other parameters are tested with is None so I don't see why types is handled differently.
from intelmq.
sebix
commented on July 17, 2024
Depends on what you check for. If "", False and None should be treated equally, use if self.types, otherwise check for the value explicitly.
"" usually appears when a bot is edited with the manager and should always be handled.
from intelmq.
Related Issues (20)
- Revisit documentation on supported OS versions and packages HOT 2
- deprecate readthedocs.io
- crontab is missing shadowserver update schema script
- Shadowserver parser docs missing part on feedname HOT 2
- intelmq.lib.exceptions.KeyExists HOT 5
- Feature Request: Shadowserver parser setting feed.documentation link HOT 1
- Upgrades error HOT 9
- documentation build workflow fails in forks
- Initial fetch of shadowserver-schema.json fails even in auto_update mode
- On Windows 10 using Msys2 / Mingw64 - ModuleNotFoundError: No module named 'grp' HOT 3
- intelmq_gen_feeds_conf: yaml.load deprecated HOT 3
- Allow sieve reuse data from the event
- CLI command in ShadowServer API collector/parser to list available report types HOT 2
- pyyaml PendingDeprecationWarning: you should no longer specify 'unsafe' -> test failure
- Shadowserver API bot HOT 8
- (doc) Documentation wrong for debian package installation
- Unhardcode paths, add more Unix support. HOT 1
- Shadowserver parser: missing documentation on auto_update
- Introduce strong formatting & linting aka black/ruff
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from intelmq.