Giter Club home page Giter Club logo

Comments (5)

FWeinb avatar FWeinb commented on August 14, 2024

You need to clearTrackState in the reverse order you started tracking it. So in your doRender() try this:

function doRender() {
  let trackId = trackState()
  app.state.Sort.Field1
  let trackId2 = trackState()
  app.state.Sort.Field2
  let paths2 = clearTrackState(trackId2)
  let paths = clearTrackState(trackId) 
}

from overmind.

fopsdev avatar fopsdev commented on August 14, 2024

thanks...but its a bit more complex because the second render may happen or not and i don't have direct control over it.
Shouldn't it work as well with 2 subsequent (= not nested) trackings as well? i would expect that because i can update the listeners with paths as many times as i want.

from overmind.

fopsdev avatar fopsdev commented on August 14, 2024

thats the failing testcase i've created. maybe it helps:

test('listener should be called after updating paths', () => {
  const tree = new ProxyStateTree({
    foo: 'bar',
    bar: 'baz',
  })
  const state = tree.get()
  let updateCount = 0
  // access foo and track it
  let trackId = tree.startPathsTracking()
  state.foo
  let paths = tree.clearPathsTracking(trackId)
  const listener = tree.addFlushListener(paths, () => {
    updateCount++
  })
  // access bar and track it
  trackId = tree.startPathsTracking()
  state.bar
  paths = tree.clearPathsTracking(trackId)
  listener.update(paths)
  // mutating foo should call listener
  tree.startMutationTracking()
  state.foo = 'bar2'
  tree.clearMutationTracking()
  tree.flush()
  expect(updateCount).toBe(1)
})

from overmind.

FWeinb avatar FWeinb commented on August 14, 2024

I don't think the test case should pass.
You are explicitly calling clearPathsTracking after accessing state.foo and therefore these paths are cleared and should not leak into the next clearPathsTracking.

startPathsTracking/clearPathsTracking should be called before and after each render cycle is done. This allows to differentiate the various nested render calls and don't leak path tracking to a parent.

Additionally the behaviour of listener.update ensures that only the tracked paths are observed for changes and there are no stall paths that will be tracked indefinitely.

from overmind.

fopsdev avatar fopsdev commented on August 14, 2024

hmm yes, i did something wrong as it looks like.
after reverting everything back to regular "nested" - tracking it works as expected :)
i think i went down the wrong route after i've recognised that a property wasn't tracked but it was accessed. now its still not tracked and i need to elaborate on that.
thanks for pushing me into the right direction :)

from overmind.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.