Giter Club home page Giter Club logo

Comments (3)

calebamiles avatar calebamiles commented on August 23, 2024

Hi Tom,

We will include a test that sets a bucket acl, namely public read-write, in
the test of POST object.

Caleb
On Oct 16, 2012 8:21 PM, "Tom Fifield" [email protected] wrote:

Hi,

one common action for many s3 clients, such as cyberduck, is to set ACLs
for a bucket at the same time as it is being created. This would be a
valuable test case, as the having the X-Amz-Acl header set could be treated
differently when creating a bucket - it caught me out when working on
swift, at least :)

I'm not sure what boto sends, but here's an example request from cuberduck:

PUT /lol/ HTTP/1.1
Date: Tue, 16 Oct 2012 22:56:57 GMT
x-amz-acl: public-read
Content-Type: application/octet-stream
Authorization: AWS admin:admin:qibESADS8jtU8aZTJa2K0KJqo1g=
Content-Length: 0
Host: 192.168.1.20:443
Connection: Keep-Alive
User-Agent: Cyberduck/4.2.1 (Mac OS X/10.8.2) (i386)


Reply to this email directly or view it on GitHubhttps://github.com//issues/2.

from s3-tests.

yehudasa avatar yehudasa commented on August 23, 2024

We shouldn't bundle this in the POST, it should have its own tests (maybe part of the bucket creation). I'm not completely sure that we don't test it yet though.

from s3-tests.

fifieldt avatar fifieldt commented on August 23, 2024

HI,

Thanks for looking into this.

Individually, you do test the functionality, i.e.:

  1. create bucket & check it is created
  2. set acl & check it is set

However, this suggestion for a new test is to set the x-amz-acl header on bucket creation - a single call, rather than first creating the bucket, then setting the acl.

from s3-tests.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.