Giter Club home page Giter Club logo

Comments (5)

mayurkale22 avatar mayurkale22 commented on May 31, 2024

If possible, please avoid to keep this package in core. Also change "monitored-resource" => "resource-util" . Same work is gonna happen in Java soon : census-instrumentation/opencensus-java#1590. It is better to consider same in Node at this stage.

from opencensus-node.

isaikevych avatar isaikevych commented on May 31, 2024

If possible, please avoid to keep this package in core. Also change "monitored-resource" => "resource-util" . Same work is gonna happen in Java soon : census-instrumentation/opencensus-java#1590. It is better to consider same in Node at this stage.

This new requirement is blocked by Resource API

from opencensus-node.

mayurkale22 avatar mayurkale22 commented on May 31, 2024

@isaikevych We discussed yesterday, this work is not blocked by anything. Please fix the PR and include #173 (comment), also pls don't include this package in core library.

from opencensus-node.

isaikevych avatar isaikevych commented on May 31, 2024

@mayurkale22
its blocked by Resources https://github.com/census-instrumentation/opencensus-java/blob/f5097ad811584ef4f5e6d8723329c4726b78432f/contrib/monitored_resource_util/src/main/java/io/opencensus/contrib/monitoredresource/util/MonitoredResourceUtils.java

List resourceList = new ArrayList();
resourceList.add(Resource.createFromEnvironmentVariables());

This changes requested by @songy23 comment

from opencensus-node.

isaikevych avatar isaikevych commented on May 31, 2024

@mayurkale22 Mayur will continue work on it as we decided on our planing
/cc @jparsana

from opencensus-node.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.