Giter Club home page Giter Club logo

Comments (5)

songy23 avatar songy23 commented on May 20, 2024 1

FYI, in Prometheus there're some restrictions on the metric names:

It may contain ASCII letters and digits, as well as underscores and colons. It must match the regex [a-zA-Z_:][a-zA-Z0-9_:]*.

So if the metric name contains '/' or other unsupported characters, you'll get this kind of error.

In Java and Go we do sanitization on metric names: https://github.com/census-instrumentation/opencensus-go/blob/master/exporter/prometheus/prometheus.go#L260.

from opencensus-node.

PikBot avatar PikBot commented on May 20, 2024

Just for reference, full code is available here.

from opencensus-node.

PikBot avatar PikBot commented on May 20, 2024

@songy23 thank you so much for pointing that out, that seemed to work! :)

from opencensus-node.

songy23 avatar songy23 commented on May 20, 2024

No problem. We probably need the same kind of sanitization in Node Prometheus exporter @isaikevych .

from opencensus-node.

songy23 avatar songy23 commented on May 20, 2024

Filed #167 to follow up. Closing this issue.

from opencensus-node.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.