Giter Club home page Giter Club logo

Comments (9)

rootulp avatar rootulp commented on August 29, 2024 1

Relevant:

TLDR: there isn't team alignment on the decision to use "hard fork" or "network upgrade" so we need to build alignment before we implement this.

from docs.

rootulp avatar rootulp commented on August 29, 2024 1

I'm fine with renaming "Lemongrass hardfork" => "Lemongrass network upgrade" if we add a redirect or fix links

from docs.

jcstein avatar jcstein commented on August 29, 2024 1

yeah, I'm on the fence about what to do so will think about this

#1552 reverted #1542 pretty quickly bc it was so jank 😅

from docs.

jcstein avatar jcstein commented on August 29, 2024

Thank you for adding the context! Yep, acknowledging that we'll need to align here first.

from docs.

jcstein avatar jcstein commented on August 29, 2024

Voting on poll is leaning toward "Network upgrade" 14-1 https://celestia-team.slack.com/archives/C01JZFUPG48/p1724260139073369

from docs.

rootulp avatar rootulp commented on August 29, 2024

I'm in favor of network upgrade.

When we address this issue, we should try to avoid breaking existing links to the docs. Or if we break the links, we should try to fix them. For example the v2.0.0 release notes link to Lemongrass hardfork.

from docs.

jcstein avatar jcstein commented on August 29, 2024

Good call out. Do you think it would be best practice to leave "Lemongrass hardfork" as is? So as to not break things for that, and going forward, use Network upgrade?

from docs.

jcstein avatar jcstein commented on August 29, 2024

While it is possible, it still feels a little jank, because you have to leave an old page up still. This is the cleanest way in Vitepress to do redirects that I know of: https://github.com/celestiaorg/docs/pull/1542/files

from docs.

rootulp avatar rootulp commented on August 29, 2024

I just tried two alternative way to configure redirects:

  1. router.addRoute
  2. rewrites

but neither worked so agreed that it's kinda jank

from docs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.