Comments (8)
lmcdasm
commented on September 26, 2024
Hey again.
Looking at the pathing against the 0.2.0 tag - it seems like the path "spec@commit-id" is somehow in there, instead of spec/schemas/artifactpackgedid.json
something from the release / build hiccup perhaps?
from sdk-go.
afrittoli
commented on September 26, 2024
Thanks @lmcdasm , that's the tag of the spec submodule.
This this the SDK tag https://github.com/cdevents/sdk-go/tree/v0.2.0
from sdk-go.
lmcdasm
commented on September 26, 2024
Hello Again.
A couple things - updated to go1.20.2
Looking in the GOHOME path after doing a cleanrun and a fresh "go get github.com/cdevents/sdk-go" i took a look inside the package and the file that is complaining - i think you can see from the directory layout "what the issue is - there is no "spec/schema" directory..
WHAT I DID:
- Cloned the source repo and then has to clone the spec.git as well (git clone https://github.com/cdevents/spec.git) into the proper place
- copied "sdk-go/pkg/api/spec" directory to my GOHOME package dir (shown above)..
- chown -R 444 the "spec" directory
After this i was able to compile - so i there is an issue when you are publishing the release with that @CommitID in the filename - not sure that is allowed in go get structure.
At any rate, i am able to get a bit further now, but naggy messages about crypto libs now - seems go issue - golang/go#58317
from sdk-go.
lmcdasm
commented on September 26, 2024
after cleaning out go remants and a "cleaner" install of go, a working build - im not sure why when i do "go get github.com/cdevents/sdk-go" why the "spec" is not coming down/i have to copy it over from the git clone of the repo but its fine.
but :) i have a working dev setup now.. yay and can start to play :)
Cheers!
dasm
from sdk-go.
afrittoli
commented on September 26, 2024
Thanks for reporting this issue @lmcdasm - it looks like the submodule does not work with go modules, I will have to find an alternate solution to embed the schema in the SDK for validation.
from sdk-go.
lmcdasm
commented on September 26, 2024
Hey there.
here is a simple way i do it in my Dockerbuild - its not "pretty" but it
works for now..
### BUILD DOCKERFILE
FROM golang:1.20.2-alpine3.17 AS build
WORKDIR /go/src/app
COPY app/go.mod ./
COPY app/go.sum ./
RUN go mod download
ENV GODEBUG=http2client=0
ENV CGO_ENABLED=1
ENV CC=gcc
RUN apk add --update gcc musl-dev bash curl git
#### HACK FOR CDEVENNTS SPEC PLACEMENT
RUN git clone https://github.com/cdevents/spec.git && cp -pr spec
,,,
...
…On Fri, Mar 31, 2023 at 6:28 AM Andrea Frittoli ***@***.***> wrote:
Thanks for reporting this issue @lmcdasm <https://github.com/lmcdasm> -
it looks like the submodule does not work with go modules, I will have to
find an alternate solution to embed the schema in the SDK for validation.
—
Reply to this email directly, view it on GitHub
<#47 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACHMXREOGR57YNWFQ4U4JQDW62WUFANCNFSM6AAAAAAWNZAEGU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
from sdk-go.
afrittoli
commented on September 26, 2024
@lmcdasm I fixed the issue at #49. Now the submodule with the spec is only used for development (when the code is generated) but there is no more a runtime dependency to the schema files.
from sdk-go.
lmcdasm
commented on September 26, 2024
Thanks so much @afrittoli !
from sdk-go.
Related Issues (20)
- Generate SDK boilerplate code HOT 2
- Align versions in the SDK to https://github.com/cdevents/spec/pull/67 HOT 1
- Improve validation on source HOT 1
- Update error in example in the README.md for cdevents.AsCloudEvent(event) HOT 2
- Fix CloudEvent Code in readme (Good First Issue) HOT 2
- Implement Incident Events in the GO SDK HOT 1
- Question - UnWrapping CloudEvent back to CDEvent HOT 2
- Update testing events in the golang SDK HOT 1
- Update License file to add copyright owner
- The CloudEvents `id` is not set
- Introduce support for multiple versions HOT 2
- Update the SDK to v0.4
- Introduce links support in the SDK
- Regenerate the SDK to include the v0.4 spec HOT 1
- Extend the templating to support new features in the v0.4 which are not supported today HOT 1
- Utilize `go generate`
- Rethink the setters paradigm
- Wrap the cloudevents client
- Allow for validation hooks
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from sdk-go.