Giter Club home page Giter Club logo

Comments (14)

paranoico avatar paranoico commented on July 29, 2024 2

@gregory You are correct, atmosphere package is NOT updated, since component has been changed from Coffeescript to Javascript and we have not finished testing all functionality we use yet.

Will review pending testing as soon as as can, thanks for the PR.

from meteor-subs-cache.

jankapunkt avatar jankapunkt commented on July 29, 2024 1

please see #39

from meteor-subs-cache.

paranoico avatar paranoico commented on July 29, 2024 1

Both PRs are merged now, my team and I will start testing next week on my side.

Sorry about my month and a half delay.

from meteor-subs-cache.

jankapunkt avatar jankapunkt commented on July 29, 2024

@paranoico @ccorcos do you really have the time to maintain this repo? Seems not to be that big but this issue still remains!?

from meteor-subs-cache.

paranoico avatar paranoico commented on July 29, 2024

@jankapunkt Sorry, I have not time yet.

Coffescript version is still working correctly and published. We cannot release JS version yet to our mobile devices. There is a problem regarding offline data gathering and then restarting device, but do not know if we have to modify this component yet.

from meteor-subs-cache.

jankapunkt avatar jankapunkt commented on July 29, 2024

Ok, seems understandable. Is there a reason, why you can't add the tests to this repo? Maybe we can provide some support in testing and find the error.

from meteor-subs-cache.

paranoico avatar paranoico commented on July 29, 2024

Well, again our time in my side is the main reason. Currently we use also ground-db and cordova-plugin-kiosk among other plugins.
So I am pretty sure the error is gound and efforts here are in that directions, I will try to add some tests as u suggest next week.
If you can provide those PR via, it will be very welcome also.

from meteor-subs-cache.

jankapunkt avatar jankapunkt commented on July 29, 2024

I can provide some tests but I only some unit tests in mocha. Would that be an improvement?

from meteor-subs-cache.

jankapunkt avatar jankapunkt commented on July 29, 2024

I already wrote some unit tests with mocha and found some inconsistencies in a helper function. I will open a PR once I have completed tests for the all functions in the api.

Maybe I find some more things to fix which may also help you with your mobile issue

from meteor-subs-cache.

paranoico avatar paranoico commented on July 29, 2024

@jankapunkt The file src/SubsCache.js does not exists in current master branch, it seems you changed its name on your PR to src/subsCache.js back again. Am I right?

from meteor-subs-cache.

jankapunkt avatar jankapunkt commented on July 29, 2024

Yes I changed the Filename to the way, how it has been referenced in the package.js File.

from meteor-subs-cache.

jankapunkt avatar jankapunkt commented on July 29, 2024

I can fix that and open a new PR, please let me know, which naming you do prefer.

from meteor-subs-cache.

jankapunkt avatar jankapunkt commented on July 29, 2024

Please see #40

from meteor-subs-cache.

paranoico avatar paranoico commented on July 29, 2024

Good @jankapunkt , thanks, and I agree file should be named SubsCache since that was the initial name @ramezrafla used on his first JS version commit months ago.

from meteor-subs-cache.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.