ViewModelBase derived classes with own SetValue method generating wrong code about catel.fody HOT 7 CLOSED

Thanks for reporting! We will try to work on this for the next release.

If you want, you can help out by either creating a PR (even if it's only the unit test, we can do the other implementations) or by considering supporting the open collective.

from catel.fody.

How should I name commit ? I did 2 files named GH0361 in respected folders with

namespace Catel.Fody.Tests.Repros
{
    using System;
    using NUnit.Framework;

    [TestFixture]
    public class GH0361TestFixture
    {
        [TestCase]
        public void WeavingWithSetValueMethodInViewModel()
        {
            var viewModelType = AssemblyWeaver.Instance.Assembly.GetType("Catel.Fody.TestAssembly.Bugs.GH0361.MyDerivedViewModel");
            var viewModel = Activator.CreateInstance(viewModelType) as dynamic;

            viewModel.Property = new object();
        }
    }
}

and

namespace Catel.Fody.TestAssembly.Bugs.GH0361
{
    using Catel.MVVM;

    public class MyDerivedViewModel : ViewModelBase
    {
        [Model]
        public TestModel Model { get; set; }
        [ViewModelToModel]
        public object Property { get; set; }

        public void SetValue(string s)
        {

        }
    }

    public class TestModel
    {
        public object Property { get; set; }
    }
}

code

from catel.fody.

To create a pull request, you would have to create a fork (right top button in GitHub). Then I personally prefer to create a separate branch (e.g. pr/setvalue-fix) and feel free to name the commits whatever feels right.

Once the PR is in place, we can commit to it as well and finalize the feature.

from catel.fody.

I did only Unit test

from catel.fody.

That's perfect. If you can create the fork + branch + unit test, we can implement the fix. We will merge once it's fully complete.

from catel.fody.

A good commit name could be: "Add unit test for SetValue override selection issue"

from catel.fody.

Closing as this is now fixed.

from catel.fody.