Add conversion for sub/super-script about jira2markdown HOT 6 CLOSED

I vote for the second rule only. The first one needs much more attention to implement and to maintain:

1. Create mapping of all available characters and it's subscript/superscript counterparts. Need to keep the mapping up to date as the new unicode sub/super-script characters are added.
2. After conversion with str.translate need to compare it char by char with the original string to confirm the 100% conversion. At the moment, I don't know how to implement this efficiently.

from jira2markdown.

In as far as mapping is concerned, I have linked a good one and we can assume nothing changes in the future in the relevant code planes.

As to comparison, I though that's actually quite easy:

FROM = "..."
TO = "..."

translated = content.translate(str.maketrans(FROM, TO))

if all(src != dst for src, dst in zip(content, translated)):
    return content
else:
    return f"<sup>{content}</sup>"

We have enough cores to not to care about efficiency :)

from jira2markdown.

Ok, I am ready to exchange efficiency for beautiful and elegant code :)

from jira2markdown.

👍

from jira2markdown.

I can't help thinking this solution will lead me to the unpredictable bugs. I would prefer to implement the simplest solution so that you can extend it as you see fit.

from jira2markdown.

Fine, I can live with that, thanks!

from jira2markdown.