Giter Club home page Giter Club logo

Comments (2)

pmeenan avatar pmeenan commented on July 21, 2024

I set up a cron job to trigger builds daily at midnight GMT. I'll keep an eye on it to make sure it is working as expected.

Feel free to submit a PR to rip out all of the in-container update code (otherwise I'll make a pass at it later today).

One thing we probably need to figure out is a clean way to shut down the agent when killing the container so updates don't just terminate in the middle of a test.

from webpagetest.agent.

sburnicki avatar sburnicki commented on July 21, 2024

I'll prepare the PR.
About gracefully killing:
The signal_handler could be connected to SIGTERM in addition to SIGINT. Then I'd write the entrypoint so it propagates the signal to the wptagent process.

By default docker stop sends SIGTERM to the main process with a grace period of 10 seconds before sending SIGKILL. However, the grace period can also set to be longer, i.e. with docker stop ----time=30 foo. This way we could allow the agent to finish the test first within a given period.

from webpagetest.agent.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.