Giter Club home page Giter Club logo

Comments (15)

catamphetamine avatar catamphetamine commented on May 19, 2024

Webpack 2 works for me with this project.

npm install [email protected]
npm install [email protected]

// Then remove OccurrenceOrderPlugin

from universal-webpack.

ignatevdev avatar ignatevdev commented on May 19, 2024

It might work with the beta.21, but it will fail at the latest and above. Are you going to do anything about it?

from universal-webpack.

catamphetamine avatar catamphetamine commented on May 19, 2024

I will make it work with Webpack 2 once it is released and stabilised (along with the corresponding 3rd party plugins).
Until then you can fork this repo and create a pull request called "Webpack 2" in which you're gonna keep the project working and up-to-date with the latest beta version of Webpack 2.

from universal-webpack.

aris-b avatar aris-b commented on May 19, 2024

I can confirm this. I don't think that the webpack beta version matters, but if you migrated to the new config syntax of webpack2 the loaders iterations will fail.

So if you changed your configuration in webpack.conf from module.loaders to module.rules it will throw a TypeError: undefined is not iterable. You can basically change that back to module.loaders and it will work just fine (webpack2 has backwards compatibility on this).

from universal-webpack.

catamphetamine avatar catamphetamine commented on May 19, 2024

Ok then, make up a sample repo, tell me the command and the error message,
and i'll have a look this evening

On Thursday, November 3, 2016, Aris [email protected] wrote:

I can confirm this. I don't think that the webpack beta version matters,
but if you migrated to the new config syntax of webpack2 the loaders
iterations will fail.


You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
#38 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAdH783lSbjsQV6C9U14Qm2Xb-T1lcJPks5q6cw3gaJpZM4KkqEi
.

from universal-webpack.

catamphetamine avatar catamphetamine commented on May 19, 2024

Since none of you provided me with a sample project reproducing the issues I made it myself and added the instructions on running webpack-react-redux-isomorphic-render-example with Webpack 2 to that repo.
catamphetamine/webpack-react-redux-server-side-render-example@952a9c7
universal-webpack has no dependency onWebpack version and worked (and works) with any Webpack version.
This repo is no place for this issue.

from universal-webpack.

ignatevdev avatar ignatevdev commented on May 19, 2024

Wow, this might be very useful, will definitely check it out. I could post a repo, but I agree with you on the point of waiting for the stable release of the webpack 2, since the config might change multiple times by that time.

However, thank you anyway.

from universal-webpack.

catamphetamine avatar catamphetamine commented on May 19, 2024

I'm personally not a fan of going with the latest hot stuff since it's almost always means finding bugs and googling the hell out of the internet.

from universal-webpack.

ignatevdev avatar ignatevdev commented on May 19, 2024

I agree, and to be honest, while trying to state the main features in webpack 2 and googling to make sure I'm correct I have found out that those things can be done with wepback 1 as well, but their support will not be native and might have some troubles to get it working. Nevertheless I would probably stick with your opinion on this one.

from universal-webpack.

catamphetamine avatar catamphetamine commented on May 19, 2024

Webpack 2 introduces tree shaking.
Which is gonna eliminate unused code and reduce bundle size drastically.
Well, at least that's how everyone thought.
Except it still doesn't work and that's the reason it says BETA.
webpack/webpack#2867

from universal-webpack.

ignatevdev avatar ignatevdev commented on May 19, 2024

Interesting. Then the effort of fixing the errors during migration to the new version are completely not worth it, since I've done everything like in your example and some more things, but still got problems with resolving paths.

from universal-webpack.

catamphetamine avatar catamphetamine commented on May 19, 2024

Post your errors

from universal-webpack.

ignatevdev avatar ignatevdev commented on May 19, 2024

Sure, but gonna do it tomorrow

from universal-webpack.

ignatevdev avatar ignatevdev commented on May 19, 2024

Back here again. My error is not anyhow related to this project, it's a webpack's issue, however, it appears because the new webpack disallows to add an empty string into resolve extensions, and it leads to a fail in the processing of some of the node_modules. But, as I said, since it's not related to this project, I leave it here only because you asked

from universal-webpack.

catamphetamine avatar catamphetamine commented on May 19, 2024

FYI the newest 0.2.0 release now only supports Webpack 2.
It works for my project.
If you find any bugs in the new version then create an issue.

from universal-webpack.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.