Grenade launcher rounds don't explode (thanks to TWO bugs at once) about cataclysm-bn HOT 5 CLOSED

I must have missed some of them. It's also a problem for mods that reuse those effects.
Ammo effect implementation is a big hack that combines actual ids (good) with hardcoded effects (bad) in one vector, but ids+regular flags (terrible) in other vector that has to be checked the same way.

I guess for now it's per-case basis fix.
Except for the whole

Extends json method doesn't actually work for ammo effects for whatever reason. This is potentially a very serious issue that affects a lot more than grenade launchers.

This one sounds serious.

from cataclysm-bn.

Reference from DDA:
CleverRaven/Cataclysm-DDA#42795

Looks like they have it also.

from cataclysm-bn.

@Cactoideae
If you know how to fix that quickly - then go for PR. We will be very thankful! It would be great!

from cataclysm-bn.

I know how to band-aid the grenade launcher issue. I can't possibly fix the underlying issue with json inheritance. It would be much better if someone competent fixed it properly. As mentioned, it affects a lot more than grenades.

I've checked, and incendiary shotgun rounds don't work either. SHOT and NEVER_MISFIRES properties probably don't work either, but they are non-trivial to test.

Rewriting all ammo without using inheritance isn't a real solution, it's a step backwards to avoid fixing the issue.

from cataclysm-bn.

So it is really serious thing then.

from cataclysm-bn.