Increase maximum energy unit limit about cataclysm-bn HOT 7 OPEN

Uh, you sure about that? #1071

from cataclysm-bn.

oh, i totally overlooked the unit tag. then it must be the debug bionic code, for some reason debug bionic capacity is capped at 2147kJ

from cataclysm-bn.

Actual limit is 2,147,483,647 joules, it USED to be 2,147,483,647 millijoules and that was exactly why it was changed. Now you can install up to 2147483 kJ power, in practice 2147450 if you mix up mark 1s and mark 2s in exactly the right combo.

from cataclysm-bn.

Also what debug option is this? I don't see any such thing in traits?

from cataclysm-bn.

debug menu -> edit bionics

from cataclysm-bn.

Oh, neat. I guess that could use a fix then. I never noticed that, I'm so used to giving myself the installation trait and manually spawning in any CBMs I need to test with...

from cataclysm-bn.

So I'm looking at this...installing new power storage calls Character::mod_max_power_level (https://github.com/cataclysmbnteam/Cataclysm-BN/blob/main/src/character.cpp#L2296) which just adds the amount to be added to current max power, and uninstall calls the same function with a negative number.

The debug function meanwhile calls Character::set_max_power_level( (https://github.com/cataclysmbnteam/Cataclysm-BN/blob/main/src/character.cpp#L2279) which just sets max power to the value. I don't see any kind of sanity checking that would logically run afoul of a power limit in either though, nor do I see anything in wish.cpp that screams "this resets power limit if above X" for that matter.

from cataclysm-bn.