Giter Club home page Giter Club logo

Comments (10)

jonorossi avatar jonorossi commented on August 16, 2024

Sure, go for it.

from core.

blairconrad avatar blairconrad commented on August 16, 2024

Great. Pull request coming real soon now. In addition to merging, the Core > Pack configuration will need to be updated to match Core Blair > Pack (which I'll remove after we're done):

  1. Build Step 1 (Get NuGet Version):
    1. change Step name to "Get Build Variables" (optional, but matches Windsor's Pack)
    2. change Script file to buildscripts\Get-NuGetVars.ps1
  2. Build Step 2 (NuGet Pack):
    1. add the following Property: CurrentYear=%CurrentYear%
  3. Build Parameters:
    1. add a new Configuration Parameter:
      • Name: CurrentYear
      • Value: 2000 (really doesn't matter, I suppose)
      • Spec: text description='Copyright Year' display='hidden' label='Copyright Year' regexp='20\d\d' validationMode='regex'
        image

(Sorry to make work for you. Too bad the build config can't just be merged.)

And I think that should just about do it. Thanks for indulging me.

from core.

jonorossi avatar jonorossi commented on August 16, 2024

I've merged the pull request. Do you mind just making the changes to the build configuration yourself. I've disabled the build agents so no builds will be running from the merge.

from core.

blairconrad avatar blairconrad commented on August 16, 2024

Happy to. Once I think I'm done, shall I re-enable the build agents?

from core.

jonorossi avatar jonorossi commented on August 16, 2024

Yep, let me know if you don't have permissions.

from core.

blairconrad avatar blairconrad commented on August 16, 2024

Re-enabled. All packages but Pack built.
Pack was showing one build queued, but no agents available because of the missing implicit requirement %CurrentYear%. I rechecked my config, and it looked good. Then I looked at the compatible agents and saw castlebuild-windows. Reasoning that maybe the queued job was stuck because it was created before I updated the configuration for Pack, I hit the build button on Pack. Worked like a charm.

I'm not sure what other test to do, besides committing something, so I'm going to remove the queued build and hope that everything's fine. I have a good feeling.

Thanks again.

from core.

jonorossi avatar jonorossi commented on August 16, 2024

Sounds about right, I'm happy for you to just remove the queued build, and we can close this.

from core.

blairconrad avatar blairconrad commented on August 16, 2024

Done and done. Removing "Core Blair" now. Thanks!

from core.

blairconrad avatar blairconrad commented on August 16, 2024

Closed via #76 and TeamCity configuration changes.

from core.

jonorossi avatar jonorossi commented on August 16, 2024

Thanks

from core.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.