Interceptor Selectors under CreateClassProxy are provided a System.RuntimeType rather than a System.Type about core HOT 3 CLOSED

Thanks for the details especially those in the SO question.

I've worked out this defect only affects CreateClassProxy and can confirm that it was introduced in 3.2.0 under DYNPROXY-175, which is why 3.1.0 works as you reported.

We don't currently have any unit tests to verify the type parameter which is why this regression unfortunately has occurred.

This is what type is for each generator method:

• CreateClassProxy: currently a System.RuntimeType because ClassProxyTargetContributor passes through a TypeTokenExpression
• CreateClassProxyWithTarget: a System.Type for the target
• CreateInterfaceProxyWithTarget: a System.Type for the target
• CreateInterfaceProxyWithTargetInterface: a System.Type for the target
• CreateInterfaceProxyWithoutTarget: null, there is no target

Unfortunately we've also got a mismatch between behaviour and documented behaviour via XML comments. type is implemented as target type, and method is implemented as documented, you can get the type declaring the method to intercept via method.DeclaringType.

public interface IInterceptorSelector
{
    /// <summary>
    ///   Selects the interceptors that should intercept calls to the given <paramref name = "method" />.
    /// </summary>
    /// <param name = "type">The type declaring the method to intercept.</param>
    /// <param name = "method">The method that will be intercepted.</param>
    /// <param name = "interceptors">All interceptors registered with the proxy.</param>
    ...
    IInterceptor[] SelectInterceptors(Type type, MethodInfo method, IInterceptor[] interceptors);
}

I'll look at getting a set of unit tests added and the fix.

from core.

Has this issue progressed any further?

from core.

No. I think I've got a patch someone in my Windows VM with a hacky fix from January, but never got back to it, the unit tests are probably the only useful bits.

from core.