Calls to other methods within the same class are not being intercepted about core HOT 4 CLOSED

I don't know Autofac Interceptors so I can't really help much.

I can tell you, however, that DynamicProxy is unable to intercept sealed methods such as your Calculator class' Add and Subtract. Try making them virtual and see what happens.

Depending on how exactly Autofac Interceptors makes use of DynamicProxy, they might even be able to get this to work for you automatically by re-implementing ICalculator, then intercept those interface methods, and possibly forward to the Calculator class' implementations if so desired. But you'd need to have a discussion about that with their team.

from core.

It does intercept Add() and Subtract() even though they aren't virtual, which goes against what's in the documentation.

Infact, it intercepts all public methods on Calculator(), except when one of these methods invokes another public method inside the same class. It only appears to intercept the very first call.

I did try making them all virtual but the behaviour is the same.

from core.

If Autofac Interceptors intercepts your sealed Calculator methods (or at least you think that this is what it does), it is much more likely that it actually reimplements ICalculator in the proxy subclass (which derives from Calculator) and intercepts those methods. If these methods then delegate to the base class implementation, and those base class methods call each other (while seeing this typed as Calculator instead of ICalculator), then interception is effectively bypassed, since the method implementations that kick off the interception sit in the more derived proxy subclass and the base class implementations never call those.

This isn't a problem with DynamicProxy, but with the specific usage pattern found in Autofac Interceptors. I have to refer you back to their team, there's nothing wrong with DynamicProxy if my guess is correct, and there's nothing we can do here.

from core.

Hi, thanks for looking into this. After much investigation over the weekend, I discovered that the interception was working to spec. The sub interception I had been told by a more experienced developer for this application wasn't actually happening, and there was other application code in play.

Sorry for wasting your time on this, but it was very interesting looking through the source.

from core.