Use different namespaces for different networks. about casper-node HOT 4 CLOSED

@Fraser999 might this be a good task for Austin when he comes on board?

from casper-node.

Given that we don't have a strong use case for this, and that it will take a fair amount of specialized testing, I don't think this is worth doing right now. Recommend moving to backlog and revisit in Q3.

from casper-node.

I think we should create subdirs named after genesis hash and not network name. Network name doesn't need to be unique – there can be two networks with the same name and different genesis hashes that would be incompatible.

from casper-node.

I think we should create subdirs named after genesis hash and not network name. Network name doesn't need to be unique – there can be two networks with the same name and different genesis hashes that would be incompatible.

I see your point, but the main issue is that the genesis hash isn't persisted across upgrades in a way in which the Storage component or the ChainspecLoader component could easily access it. When a non-genesis version of node starts up, it pretty much immediately needs to know where to access the DB files from the previous run.

I think since this ticket is non-critical, i.e. it's designed to help users avoid a simple footgun, it's probably enough to just use the network name here.

Of course, if I'm missing an easy way for the genesis hash to be given to the Storage constructor of a non-genesis version, I'd be inclined to agree with your suggestion.

from casper-node.