Giter Club home page Giter Club logo

Comments (7)

lld2001 avatar lld2001 commented on June 30, 2024

After override the eldoc-box--at-point-x-by-company, it looks better.

(defun eldoc-box--at-point-x-by-company ()
  "Return the x position that accommodates company's popup."
  (if company-box--x
	  (+ company-box--x (* (frame-char-width (company-box--get-frame))
					(frame-parameter (company-box--get-frame) 'width)))
	nil))

image

from eldoc-box.

casouri avatar casouri commented on June 30, 2024

Thanks, could you redefine the function to the following and see if it works? Thanks.

(defun eldoc-box--at-point-x-by-company ()
  "Return the x position that accommodates company's popup."
  (cond
   ((and (boundp 'company-pseudo-tooltip-overlay)
         company-pseudo-tooltip-overlay)
    (+ (* (frame-char-width)
          (+ (overlay-get company-pseudo-tooltip-overlay
                          'company-width)
             (overlay-get company-pseudo-tooltip-overlay
                          'company-column)))
       (or (line-number-display-width t) 0)))
   ((and (boundp 'company-box--x) (numberp company-box--x))
	(+ company-box--x
       (frame-pixel-width (company-box--get-frame))))
   (t nil)))

from eldoc-box.

lld2001 avatar lld2001 commented on June 30, 2024

Works as expected. But if company-pseudo-tooltip-overlay set to t, it will fail.

image

from eldoc-box.

casouri avatar casouri commented on June 30, 2024

Why would company-pseudo-tooltip-overlay be set to t?

from eldoc-box.

lld2001 avatar lld2001 commented on June 30, 2024

I found (and (featurep 'company) company-pseudo-tooltip-overlay) in fun eldoc-box--at-point-x-by-company previously. So I set it to t. When using company-box, this variable is no longer necessary.

from eldoc-box.

casouri avatar casouri commented on June 30, 2024

Yeah, it won't be a problem in normal operation. Cool. I'll push this change soon, thanks for the report!

from eldoc-box.

lld2001 avatar lld2001 commented on June 30, 2024

The issue is fixed. Thank you.

from eldoc-box.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.