Why doesn't casbin_rule add an auto increment primary key? about gorm-adapter HOT 11 CLOSED

I don’t quite understand why you don’t increase the primary key field. According to the mysql innodb index design, it is recommended to provide an ID primary key

from gorm-adapter.

I guess the Casbin don't need the ID primary key.

from gorm-adapter.

@aofengli can you make a PR to add an increment primary key?

from gorm-adapter.

@00LT00 can you take this issue?

from gorm-adapter.

I'm learning about it and solving it as soon as possible

from gorm-adapter.

1. When casbin is loaded, it has already loaded from database to memory. So the database is not selected during runtime. The primary key has no effect on select operations.
2. Because the gorm-adapter just is a tool to get policy. The struct in memory must be the same as "policy.csv". In fact, the primary key cannot be used at all when deleting.

In summary, I think we shouldn't add ID primary key for casbin.
What do you think? @aofengli @hsluoyz

from gorm-adapter.

I don’t quite understand why you don’t increase the primary key field. According to the mysql innodb index design, it is recommended to provide an ID primary key

@aofengli can you make a PR to fix it?

from gorm-adapter.

@hsluoyz We should add unique index.

from gorm-adapter.

OK. Can anyone work on a PR?

from gorm-adapter.

@hsluoyz @nodece add unique index

from gorm-adapter.

PR made: #54

from gorm-adapter.