Giter Club home page Giter Club logo

Comments (9)

tangyang9464 avatar tangyang9464 commented on June 12, 2024 1

@JalinWang plz revert PR: #157

@hsluoyz I think we should extend #168 to support v7 instead of revert

from gorm-adapter.

casbin-bot avatar casbin-bot commented on June 12, 2024

@tangyang9464 @JalinWang @imp2002

from gorm-adapter.

hsluoyz avatar hsluoyz commented on June 12, 2024

We added v6 and v7 because of this issue: #151

@zz541843 can we revert the PR?

from gorm-adapter.

hsluoyz avatar hsluoyz commented on June 12, 2024

@tangyang9464 what's your opinion?

@JalinWang

from gorm-adapter.

JalinWang avatar JalinWang commented on June 12, 2024

Maybe we need to extend #168 to a more flexible schema?

from gorm-adapter.

hsluoyz avatar hsluoyz commented on June 12, 2024

@JalinWang plz revert PR: #157

from gorm-adapter.

tangyang9464 avatar tangyang9464 commented on June 12, 2024

Maybe we need to extend #168 to a more flexible schema?

@JalinWang I think so.

from gorm-adapter.

reckless-huang avatar reckless-huang commented on June 12, 2024

@JalinWang plz revert PR: #157

@hsluoyz I think we should extend #168 to support v7 instead of revert

every thanks , what time for merge #168

from gorm-adapter.

hsluoyz avatar hsluoyz commented on June 12, 2024

@tangyang9464 @JalinWang I still think we should make it simple and just use up to v5 element. The user can fork the library and extend elements as they want. Supporting customizing it will take a lot of efforts for our maintainers team. We may need two weeks to just finish: #180 and this is only one adapter. Remember we have 20+ adapters only for Golang and it will be a disaster to support them all. Not to mention we have 10 more other languages, Java, Python, Node.js, PHP, .NET and each language will have a bunch of adapters. This is something we cannot afford to do with the current development team. Moreover, I don't think it's very meaningful. Just fork it and extend to v7 or v17. It's already so easy. Don't waste tons of our development team's efforts to just fix this small issue.

from gorm-adapter.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.