RbacApi::delete_permissions_for_user seems to be no-op about sqlx-adapter HOT 9 CLOSED

I think a way to fix it is to change adapter::remove_filtered_policy to accept vectors of any length and change query based on length.

from sqlx-adapter.

@andoriyu can you make a PR?

from sqlx-adapter.

@smrpn @hackerchai @PsiACE @GopherJ

from sqlx-adapter.

Using debugger, I narrowed down the issue to this area of the code:

    async fn remove_filtered_policy(
        &mut self,
        _sec: &str,
        pt: &str,
        field_index: usize,
        field_values: Vec<String>,
    ) -> Result<bool> {
        if field_index <= 5 && !field_values.is_empty() && field_values.len() >= 6 - field_index {
            adapter::remove_filtered_policy(&self.pool, pt, field_index, field_values).await
        } else {
            Ok(false)
        }
    }

field_values.len() is 0, so it short circuits to Ok(false) branch.

from sqlx-adapter.

@PsiACE

from sqlx-adapter.

@andoriyu can you make a PR?

@hsluoyz sure I will try to put it together later today (PDT).

Would you be open if I change casbin-rs API a bit? (not in this PR)

Right now, Rule is Vec<String>. I can make polymorphic and accept things like: [String; N], tuples with up to 6 values etc.

from sqlx-adapter.

@andoriyu we should not introduce breaking change. But we can add appropriate new APIs.

from sqlx-adapter.

@hsluoyz the I was thinking doing would keep backward compatibility, just in addition to Vec<String> in will take other things.

from sqlx-adapter.

@andoriyu no breaking change then OK!

from sqlx-adapter.