Giter Club home page Giter Club logo

Comments (7)

skyguy94 avatar skyguy94 commented on June 25, 2024 1

👍 Works on our agents. ty!

from xunit-teamcity.

carlpett avatar carlpett commented on June 25, 2024

Hi!
Thanks for reporting! There is an assumption in the plugin code, here, that all compatible build agents will have .net 4.0, which causes this.
I'll have a dig through JetBrains Javadocs to see if there is some better way to figure out if the agent can execute the test runner.

from xunit-teamcity.

skyguy94 avatar skyguy94 commented on June 25, 2024

I did come across that code yesterday and I thought that the .Exists option might be changed to something like VER_NO_LESS_THAN. I was going to give that a try on Monday.

Also, I opened a bug with TC as I believe they still should be reporting the runtime for tooling support while using the targeting pack for building/compiling. https://youtrack.jetbrains.com/issue/TW-46352

from xunit-teamcity.

carlpett avatar carlpett commented on June 25, 2024

The problem is that all the requirements act on a single agent property (such as DotNetFramework4.6_x64), and all there is no property which contains "highest .net framework version installed", instead there are many properties which exist if the corresponding version is installed. So I don't think the VER_NO_LESS_THAN route will work, sadly.
I'm installing TC10 on my test server now so that I can experiment a bit.

from xunit-teamcity.

carlpett avatar carlpett commented on June 25, 2024

Turns out there is a syntax for using regex in the requirements. I've updated to use that instead, and it looks good on my machine (TC 10.0 and 9.1.6). It is included in release 1.1.2

from xunit-teamcity.

skyguy94 avatar skyguy94 commented on June 25, 2024

Outstanding. I'll push it out to our agent pool and give it a go.

from xunit-teamcity.

 avatar commented on June 25, 2024

Hi, All!
As for change in TeamCity ,net runtime reporting, The idea is the following. As all .NET 4.x updates are in-place so after you install .NET 4.6 on top of .NET 4.0 you don't actually have 4.0 runtime anymore. But Targeting Pack still exist. So starting from 10.0 TeamCity reports this case properly in my point of view.
As for provided fix in xUnit runner, I left my comment near commit.

from xunit-teamcity.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.