Muliple segmentations fault with CS_OPT_SKIPDATA about capstone HOT 3 CLOSED

FYI I can work on a pull request if you agree with my proposed solution

from capstone.

On Wed, May 7, 2014 at 7:16 PM, Giovanni Condello
[email protected]:

Whenever an instruction is marked as SKIPDATA, capstone should not try to
access insn->detail as it will be null thus causing segmentations fauls
(see, for example, cs_insn_group).

I think the correct way to handle this is to

• Set handle->errnum to CS_ERR_SKIPDATA if insn is actually skipped
  due to CS_OPT_SKIPDATA

currently we set insn.id = 0 to reflect that the instruction is
irrelevant, so why do we still need to set errnum?

• Always check for insn->detail to be not null before accessing it

this is what we already did in all tests/test*.c code: checking
insn->detail before dereferencing it.
i believe this is also documented in capstone.h

• (Maybe throwing something more different from CS_ERR_DETAIL to
  identify the two cases)

by "throwing something", are you talking about the bindings (Java, Python?)

let me know if i still miss something.

anyway, Pull Request is always welcome, as it is a best way to demonstrate
what you are saying :-)

thanks.
Q

from capstone.

Closing this one, let's continue on #107

from capstone.