Giter Club home page Giter Club logo

Comments (6)

CappielloAntonio avatar CappielloAntonio commented on May 28, 2024 1

Hey @dnno thanks for reporting!
I fixed the playlists issues, you can see the code and test if all the issues are now fixed.

from tempo.

CappielloAntonio avatar CappielloAntonio commented on May 28, 2024 1

This is the commit mentioned above 1eda7ce

from tempo.

dnno avatar dnno commented on May 28, 2024

There's a remaining NPE, I opened a PR, see #47

from tempo.

CappielloAntonio avatar CappielloAntonio commented on May 28, 2024

Yes, I fixed that problem as well.
I did it a priori, even before giving the adapter class the result of the server call:

playlistEditorViewModel.getPlaylistSongLiveList().observe(requireActivity(), songs -> {
    if (songs != null) {
        playlistDialogSongHorizontalAdapter.setItems(songs);
    }
});

In this way, inside the adapter, the list will never be null, at most empty.

from tempo.

dnno avatar dnno commented on May 28, 2024

Oh, I'm sorry, my fork sync missed that commit, it seems. bad timing...

from tempo.

CappielloAntonio avatar CappielloAntonio commented on May 28, 2024

No, don't apologize, it was me who pushed online waiting a few minutes between one commit and another

from tempo.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.