Giter Club home page Giter Club logo

Comments (6)

stewones avatar stewones commented on May 28, 2024 1

yes you right good catch. we should get rid of that import too

from fcm.

stewones avatar stewones commented on May 28, 2024 1

@stewones FirebaseCore should probably be also removed from.. https://github.com/capacitor-community/fcm/blob/master/CapacitorCommunityFcm.podspec#L13 ? I guess.

Yeah, I will patch asap

from fcm.

stewones avatar stewones commented on May 28, 2024

Your existing project might have some plugin which requires it, but fcm itself doesn't. Did you try adding FirebaseCore in your app pod?

from fcm.

cgadam avatar cgadam commented on May 28, 2024

@stewones , yep, once I added to my project's pod, it did work.

Turns out Firebase Core is still being used by the code injected by the plugin here:
https://github.com/capacitor-community/fcm/blob/master/ios/Plugin/Plugin/Plugin.swift#L6

And if you remove Firebase Core you won’t be able to do:
https://github.com/capacitor-community/fcm/blob/master/ios/Plugin/Plugin/Plugin.swift#L21

from fcm.

cgadam avatar cgadam commented on May 28, 2024

@stewones FirebaseCore should probably be also removed from.. https://github.com/capacitor-community/fcm/blob/master/CapacitorCommunityFcm.podspec#L13 ? I guess.

from fcm.

stewones avatar stewones commented on May 28, 2024

@cgadam can you please try a fresh install from 1.1.2 ?

I did test with the example inside this project and it worked just fine. the reason I removed FirebaseCore from the plugin podspec is because it's already being installed as a peer dependency by FirebaseMessaging as you can see in here

https://cocoapods.org/pods/FirebaseMessaging

I'm closing for now but feel free to reopen

Thank you

from fcm.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.