Giter Club home page Giter Club logo

Comments (7)

Canop avatar Canop commented on June 2, 2024 1

To force the theme, do

imports: [
    verbs.hjson
    skins/dark-gruvbox.hjson
]

from broot.

Canop avatar Canop commented on June 2, 2024

Broot correctly detects it's a light theme though

Are you sure ? Can you have a look at the debug log ?

from broot.

apraga avatar apraga commented on June 2, 2024

Interesting. It is detecting the light theme in both case but apply the dark theme ?
In zellij

19:15:25.548 [DEBUG] broot::display::luma: terminal_light::luma() took 421.902µs
19:15:25.548 [INFO] broot::display::luma: terminal's luma: Ok(0.15625)
19:15:25.548 [DEBUG] broot::conf::conf: reading conf file: "/home/alex/.config/broot/skins/dark-gruvbox.hjson"
19:15:25.550 [DEBUG] broot::conf::conf: skipping not applying conf file : "skins/solarized-light.hjson"


Outside zellij

19:14:47.681 [DEBUG] broot::display::luma: terminal_light::luma() took 209.449µs
19:14:47.681 [INFO] broot::display::luma: terminal's luma: Ok(0.96371955)
19:14:47.681 [DEBUG] broot::conf::conf: skipping not applying conf file : "skins/dark-gruvbox.hjson"
19:14:47.681 [DEBUG] broot::conf::conf: reading conf file: "/home/alex/.config/broot/skins/solarized-light.hjson"

I've edited the issue with the full configuration for dark and light theme.

from broot.

Canop avatar Canop commented on June 2, 2024

In your first log (zellij), the terminal is seen as dark (luma = 0.15625), and the dark theme is applied

from broot.

Canop avatar Canop commented on June 2, 2024

It's a little weird. There are many reasons to not be able to detect the background color, but there should not be any wrong detection.

If you're always on a light background, an obvious workaround is to just not detect and always apply the light theme.

from broot.

apraga avatar apraga commented on June 2, 2024

Here's a screenshot of the whole zellij windows :

zellij

Maybe the black borders are confusing the luma computation ? I'm switching between dark and light depending on the time of the day :)

Edit could you show how to force a given theme whatever the luma ? Thanks.

from broot.

apraga avatar apraga commented on June 2, 2024

Further testing: same results in other shells (fish, sh, initially tested with nushell).
I've tested (at least I hope) your strategy in terminal-light using terminal escape code. In zellij

~> printf "\x1b]11;?\x07"
~> ]11;rgb:fbfb/f1f1/c7c7

Outside zellij

 ~/.c/broot> printf "\x1b]11;?\x07"
~/.c/broot> ]11;rgb:2828/2828/2828^C

By the way, feel free to move the issue in terminal-light !

from broot.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.