Giter Club home page Giter Club logo

Comments (4)

steverydz avatar steverydz commented on July 19, 2024

@nottrobin @jpmartinspt are we able to open up the cors permissions for assets.ubuntu.com?

Because the canvas for each banner contains images from assets.ubuntu.com I'm not able to convert the canvas to a dataURL (for downloading purposes) unless cors allows it for the embedded images.

from tools.demos.haus.

nottrobin avatar nottrobin commented on July 19, 2024

We can't make changes to assets until we move it to k8s, but also, it's difficult to see how this could be supported in assets.ubuntu.com in general. We'd need to look quite deeply into the security implications of "opening up cors permissions".

The faster solution would be that any images you needed cross-site access to were hosted elsewhere, or you found a way to grab the necessary images from assets.ubuntu.com server-side.

from tools.demos.haus.

steverydz avatar steverydz commented on July 19, 2024

Thanks @nottrobin.

It's most likely that the images will come from assets as that's where our illustrations are hosted, although technically the user can put any URL for the illustration they want to use, so opening up assets would only partially solve the issue.

The problem with fetching the image server side is that it would have to be hosted within the app, which means we would be hosting a second assets server of sorts.

I don't see a way around this so I think the only thing we can do is prompt the user to right click/save image.

from tools.demos.haus.

nottrobin avatar nottrobin commented on July 19, 2024

The problem with fetching the image server side is that it would have to be hosted within the app, which means we would be hosting a second assets server of sorts.

Not necessarily - we could instead proxy live through the backend app. As in, tools.demos.haus/getmemyimage?url=https://assets.ubuntu.com/v1/something.jpg.

from tools.demos.haus.

Related Issues (16)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.