Giter Club home page Giter Club logo

Comments (3)

bloodearnest avatar bloodearnest commented on June 10, 2024

Hmm, this is an interesting one. Agreed that IP address makes no sense as part of the metric name. An application specified name for the upstream does make sense, but I'm not sure the best way to set that.

from talisker.

thomir avatar thomir commented on June 10, 2024

We've worked around this in our services themselves. However, talisker still emits it's per-request metrics. Perhaps as a half-way solution we could have a way to turn those off, since at this point they're just noise...

Cheers 😄

from talisker.

bloodearnest avatar bloodearnest commented on June 10, 2024

Fixed in #171, released in 0.9.7.

You can now do:

session.post(..., metric_api_name='api', metric_host_name='myservice')

And the metric name will take these into account, e.g.

requests.count.myservice.api:...
requests.latency.myservice.api.GET.200:...
requests.errors.myservice.http.api.200:...

from talisker.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.