Comments (3)
Hmm, this is an interesting one. Agreed that IP address makes no sense as part of the metric name. An application specified name for the upstream does make sense, but I'm not sure the best way to set that.
from talisker.
We've worked around this in our services themselves. However, talisker still emits it's per-request metrics. Perhaps as a half-way solution we could have a way to turn those off, since at this point they're just noise...
Cheers 😄
from talisker.
Fixed in #171, released in 0.9.7.
You can now do:
session.post(..., metric_api_name='api', metric_host_name='myservice')
And the metric name will take these into account, e.g.
requests.count.myservice.api:...
requests.latency.myservice.api.GET.200:...
requests.errors.myservice.http.api.200:...
from talisker.
Related Issues (20)
- How prometheus is supposed to collect metrics from celery? HOT 2
- AttributeErrortalisker.prometheus in write_metrics HOT 2
- Alternative bind address for status endpoints HOT 2
- Talisker incompatible with Flask 1.1.1 (No module named 'werkzeug.wrappers.json') HOT 1
- Add support for websockets
- Should Talisker define a "gevent" extra? HOT 5
- Support for Python 3.8 + gevent
- talisker.requests.TaliskerAdapter doesn't respect proxy config when selecting a backend
- Talisker breaks ipdb for gunicorn gevent HOT 4
- IPDB doens't work with Talisker HOT 1
- Preventing request IP addresses from being logged
- support newer celery (>= 4.4) HOT 1
- Support for Django > 2.0 HOT 1
- Providing Config.__getitem__() is error prone HOT 4
- Talisker not published on PyPI HOT 3
- docs have not been built for more than a year HOT 4
- Activate dependabot HOT 1
- documentation broken
- CI broken HOT 1
- tests broken
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from talisker.