Comments (8)
Yeah sure!
from metric_units_reddit_bot.
Yes, coding guidelines would be an excellent idea! I personally think ' looks better, but maybe it's worth researching what JavaScript standards are? I'm not too picky on what the formatting is, as long as it's consistent.
Maybe we can find a linter that automatically runs and enforces style, to reduce the human effort required? I haven't looked into it much so I don't know if such a thing exists, but I'm guessing it should
from metric_units_reddit_bot.
I think adding jshint
to travis-ci should be quite easy. This way we could configure jshint through .jshintrc
and have it run on every build.
from metric_units_reddit_bot.
That looks like an interesting tool! Do you want to take a stab at setting it up @nicoferraro96 ?
from metric_units_reddit_bot.
I think this makes a lot of sense, especially now that more people are contributing as a result of Hacktoberfest.
@nicoferraro96 Are you thinking of extending an existing style guideline with jshint
or are you going to add a few rules just as a sort of starting point?
from metric_units_reddit_bot.
@chazzlabs My idea was to base the config on an existing style guideline and maybe add/remove some rules, depending on if they make sense or not for this project. If you have any suggestions I would be glad to hear them
from metric_units_reddit_bot.
@nicoferraro96 I don't know of any popular style guides for jshint
. Personally I use eslint
and usually use AirBnb's style guide, but that's really more for front-end development.
I like using some other popular guide as a base because it feels like I'm starting with something that's more "standard" within the community. I'd only be concerned about the style guide potentially requiring a lot of changes to fix the initial batch of issues it might bring up. In that case, overriding some rules like you mentioned will probably help a lot. I just wouldn't want anyone who's contributing to be overwhelmed or confused by their code suddenly not meeting the guidelines.
from metric_units_reddit_bot.
@chazzlabs I had forgotten about airbnb's eslint config, now that you mention it I think I'm going to try that first.
Maybe what we could do is first adding the linter and the corresponding travis config, but not enable it and update the contribute.md encouraging contributors to use the linter and comply with it as much as possible.
We could also open a separate issue to bring the current code up to standard.
from metric_units_reddit_bot.
Related Issues (20)
- Refactor number parsing HOT 1
- Bug report: Add ignore keywords to "cups" for gaming sub reddits
- Feature request: Add unit `qt` = 1/4 gallon HOT 3
- Range conversion "30-50lb" converted to "30 lb50 lb ≈ 1423 kg"
- Scan the r/homebrewing thread and post constructive feedback in r/metric_units HOT 2
- Move documentation to /docs folder HOT 5
- bot off HOT 1
- Discussion - Discussions HOT 2
- Handle commas better HOT 16
- Always add L/100km conversion
- "oz" is not being converted to "troy oz" in subreddit /r/Pmsforsale HOT 27
- Ignore all nba subreddits for mpg HOT 10
- Ignore "cup" measurements over 100 HOT 2
- Feature request: Convert lbs/inch to kg/mm and N/m HOT 4
- Handle close numbers better HOT 1
- Conversions architecture overhaul
- Modify pressureMap to convert 10^5 pa to bar HOT 4
- Improve rounding HOT 4
- Bot should sass users who edit their comments to remove values HOT 7
- change footer links and text HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from metric_units_reddit_bot.