[BUG] - setOnSetImageUriCompleteListener can't use lambda form anymore for the interface OnSetImageUriCompleteListener about android-image-cropper HOT 7 CLOSED

OK here:
main...AndroidDeveloperLB:main
#104

from android-image-cropper.

Thanks for pointing this, for sure is an improvement we can do it.

We didn't when we convert from Java because this would change the method notation, right know the difference is from using lambda to usage of creating the Listener class.

If we decide to use the Kotlin we don't need to define an interface anymore, I mean the code interface OnSetImageUriCompleteListener doing this we need to be sure that Java and Kotlin keep working.

Was not that we didn't look enough, the library was not update since 2018 there was a lot of bugs and fixes to put in place we cannot do all at once. So we decide to not break.

Please feel free to join us and drop a PR. This would be an amazing momento to create the Java Sample code, so we can test this changes. Probably the version 3.0

from android-image-cropper.

@Canato I didn't mean I wrote in Java. this is in Kotlin.
When the library is in Java, it allows Kotlin (and Java) developers to use the shorter form.
All you need to do is to add "fun" for this interface (and others) in Kotlin, when possible.

from android-image-cropper.

Sorry, maybe I was confusing on my worlds. I meant we need to keep the library working for Kotlin and Java after the changes. So we need to test, something simple.

Same as the other ticket, for sure is something we should do and something I want to do, but this is low on my priority now.
I try to order: Samples (so we can test), refactor, fixing bugs, dealing with deprecation, adding very asked features, improve in general (lamba/comments/doc/etc)

But feel free to add it ^^

from android-image-cropper.

@Canato As I'm not so familiar with how the library works, I prefer only to give advice and feedback as a user of it.
In this case, it's quite easy. Add "fun" for each interface in Kotlin that you can.

from android-image-cropper.

Don't worry, I don't wanna be the only merging in the lib, I just handover the repo, but I hope this can be a community work. If you make the changes and test the samples in the sample app everything should be safe.

If something is missing and I know I can tell on the PR, but myself just have 4 months touching the lib. So much to learn too

from android-image-cropper.

Seems now it's possible again to use the short form again. Weird that the IDE doesn't suggest it though.

from android-image-cropper.