inline-images and color don't work together about candy-plugins HOT 6 CLOSED

Hi,

yes with the current architecture this is a problem. We are currently changing the structure on how plugins can hook into certain events but it's not 100% finished yet.

You could patch either the colors or the inline-images plugin for now with something like this (before the beforeShow handler gets overwritten):

var oldBeforeShow = Candy.View.Event.Message.beforeShow;
Candy.View.Event.Message.beforeShow = function(args) {
  oldBeforeShow(args);
  // ....
}

from candy-plugins.

Thanks for the tip!
Also wanted to point out that inline-images plugin was not working with current Candy version at all.
handleBeforeShow was expecting message argument (which probably was the case when it was written over the year ago) but currently argument is an object args. I merged the fix.
Developer for this plugin was not responding and may not be available.
Somebody else might need to approve this fix.

from candy-plugins.

The solution above - doesn't work by the way. It calls default empty beforeShow function.

from candy-plugins.

For now I just merged beforeShow code from colors (1 line) into inline-images method.
The colors plugin is initialized first and inline-images last and then it works.

from candy-plugins.

@eluzgin ok that's another solution.
I hope I can soon merge the jquery events branch into the dev branch and then soon release a new version.. Then such workarounds aren't needed anymore.

from candy-plugins.

Should work now as we have the new jquery event model.

from candy-plugins.