Comments (6)
Hi,
yes with the current architecture this is a problem. We are currently changing the structure on how plugins can hook into certain events but it's not 100% finished yet.
You could patch either the colors or the inline-images plugin for now with something like this (before the beforeShow handler gets overwritten):
var oldBeforeShow = Candy.View.Event.Message.beforeShow;
Candy.View.Event.Message.beforeShow = function(args) {
oldBeforeShow(args);
// ....
}
from candy-plugins.
Thanks for the tip!
Also wanted to point out that inline-images plugin was not working with current Candy version at all.
handleBeforeShow was expecting message argument (which probably was the case when it was written over the year ago) but currently argument is an object args. I merged the fix.
Developer for this plugin was not responding and may not be available.
Somebody else might need to approve this fix.
from candy-plugins.
The solution above - doesn't work by the way. It calls default empty beforeShow function.
from candy-plugins.
For now I just merged beforeShow code from colors (1 line) into inline-images method.
The colors plugin is initialized first and inline-images last and then it works.
from candy-plugins.
@eluzgin ok that's another solution.
I hope I can soon merge the jquery events branch into the dev branch and then soon release a new version.. Then such workarounds aren't needed anymore.
from candy-plugins.
Should work now as we have the new jquery event model.
from candy-plugins.
Related Issues (20)
- split plugins repos up HOT 2
- notifyMe: support @channel for global notifications
- Ability to paste images into the chat HOT 1
- nickchange after change does not show nick on list
- better inline-videos parsing HOT 4
- Bookmarks plugin should store in private XML storage as well
- Bookmarks plugin always stores only one bookmark on Prosody HOT 1
- Notifications - closetime option on Chrome 47+ HOT 3
- Static Lobby plugin causes "Connecting..." dialog to never close
- inline-videos plugin enables XSS attack HOT 7
- available-rooms: hardcoded MUC service JID HOT 9
- notifyme must be initialized before medoes for the latter to work HOT 2
- Inline Video's makes some content disappear HOT 3
- MUC Room Bar loads naked domain on the left of Candy
- Request: A plugin to open a chat with one of my contacts HOT 6
- Help Required: Custom hardcoded text colors
- AvailableRooms does not appear HOT 2
- `grunt watch` not working
- XEPs and RFCs support page with version
- Jingle Plugin HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from candy-plugins.