Would be nice if packaging were available for el 7. If packages could be built and pushed to epel that would make it much easier to install and use.

profile add with --auth=[nonexistent auth] gives traceback, should just print 'auth doesn't exist' - same with nonexistent ssh keyfile, etc

rho scan --range needs a decryption password (which it probably shouldn't)

adding a duplicate profile, causes traceback

rho seems to get stuck scanning some ilo's that are on our network. If I watch lsof I can see the connections, and then they eventually disappear. I get these messages as they do:

2015-12-17 10:43:20,575 paramiko.transport INFO - Disconnect (code 2): Protocol Timeout (transport/1428)
2015-12-17 10:43:21,670 paramiko.transport INFO - Disconnect (code 2): Protocol Timeout (transport/1428)
2015-12-17 10:43:22,949 paramiko.transport INFO - Disconnect (code 2): Protocol Timeout (transport/1428)
2015-12-17 10:43:24,369 paramiko.transport INFO - Disconnect (code 2): Protocol Timeout (transport/1428)
2015-12-17 10:44:24,480 paramiko.transport INFO - Disconnect (code 2): Protocol Timeout (transport/1428)
2015-12-17 10:44:25,398 paramiko.transport INFO - Disconnect (code 2): Protocol Timeout (transport/1428)

And then nothing else happens. rho hangs indefnitely after that -- it doesn't seem to recognize that the ssh jobs have expired.

strace doesn't help -- it just shows all threads hanging on futex()

I think this is happening while rho is trying to login with different auth's.

Given the reliability issues I'm seeing in #15, it would be nice if rho wrote out the report occasionally so that if the tool needs to be killed due to hanging, some amount of reporting would still be available.

Or catch ^C and generate a report at abnormal exit.

Some of the subnets I need to scan are quite large and having to scan the repeatedly as I debug issues is not friendly to our subnets :). In many cases a partial report would be good enough. (or as in #15, the scan is actually done, rho just won't exit due to zombie ssh threads.)

Periodic would probably only work with the --output option -- not stdout.

KVM guests that have the /dev/kvm device, show up as virt-hosts. Maybe another characteristic can be used to determine whether or not a machine is a KVM virtual machine, like the existence of virtio devices in lspci output?

on my test server with KVM on it, my guests often show up as virt-host
instead of virt-guest. Do I file an issue for this, or could that be
related to my setup here?

That could be due to setup although it's probably unlikely. Looking back at the rho code
it looks like the only case that would happen is if the /dev/kvm device
exists on the system. [...]

edit field in given auth

ports not validated for valid values i.e. -1 or 333333 is accepted.

if we try to add/edit a profile and give it an auth that doesn't exist, we
get an exception, and then the config is busted.
Profile f11-bogus-multiauth-multiport edited
[adrian@alikins rho]$ rho dumpconfig
Traceback (most recent call last):
File "/home/adrian/src/rho/bin/rho", line 22, in
CLI().main()
File "/home/adrian/src/rho/src/rho/cli.py", line 95, in main
cmd.main()
File "/home/adrian/src/rho/src/rho/clicommands.py", line 133, in main
self.config = self._read_config(self.options.config, self.passphrase)
File "/home/adrian/src/rho/src/rho/clicommands.py", line 98, in _read_config
return config.ConfigBuilder().build_config(confstr)
File "/home/adrian/src/rho/src/rho/config.py", line 289, in build_config
config = Config(auths=creds, profiles=profiles)
File "/home/adrian/src/rho/src/rho/config.py", line 93, in init
self.add_profile(profile)
File "/home/adrian/src/rho/src/rho/config.py", line 134, in add_profile
c)
rho.config.ConfigError: No such credentials: rsa_key

I was reviewing the code per my other bug report -- at one point I thought maybe the commands were timing out. I noticed a timeout isn't included in exec_command(). I'm wondering if that might be something you want to add, i.e.,

     def run_cmds(self, ssh_job,):
         for rho_cmd in ssh_job.rho_cmds:
             output = []
             for cmd_string in rho_cmd.cmd_strings:
-                stdin, stdout, stderr = self.ssh.exec_command(cmd_string)
-                output.append((stdout.read(), stderr.read()))
+                try:
+                    stdin, stdout, stderr = self.ssh.exec_command(cmd_string, timeout=30)
+                    output.append((stdout.read(), stderr.read()))
+                except paramiko.SSHException as e:
+                    log.error("Exception on %s: %s" % (ssh_job.ip, e))
             rho_cmd.populate_data(output)

Also, on the catch, perhaps stdin, stdout, stderr ought to be set to "", "", "". ...And the value of 30 was arbitrary.

prompt for ssh passphrase

Merge master into dev so the merge from dev into master goes cleanly.

if we try to "rho profile edit" a profile that doesnt exist:
Traceback (most recent call last):
File "/home/adrian/src/rho/bin/rho", line 22, in
CLI().main()
File "/home/adrian/src/rho/src/rho/cli.py", line 95, in main
cmd.main()
File "/home/adrian/src/rho/src/rho/clicommands.py", line 136, in main
self._do_command()
File "/home/adrian/src/rho/src/rho/clicommands.py", line 461, in _do_command
g.ranges = self.options.ranges
AttributeError: 'NoneType' object has no attribute 'ranges'

we write stuff to stdout that should be stderr, needs clean up

profile add --range: the range string should be validated for format at profile creation