Allow passing a document node or nodelist about in-view HOT 5 CLOSED

Ultimately I would not even accept string based selectors. For such a low level library, no magic is fine. Accept only Node or Node Lists :)

from in-view.

@vvo @bertez I agree, it would be nice to just pass a Node or NodeList.

One nice thing about using string selectors is that we can use it as a key to keep track of registered handlers for that selector.

inView('.selector').on('enter', el =>
    el.classList.add('in-view'));

inView('.selector') // returns the same registry as above

If we add the ability to use Node & NodeList, it will be up to the user to maintain a reference to that registry.

const registry = inView(document.querySelectorAll('.selector'));

Admittedly, that's not the worst thing. It wouldn't break any existing functionality.

from in-view.

Thanks for this great library!

I'd also like to see an option to pass an Array of nodes as I'm using jQuery and it returns an Array of nodes, not NodeList. This would make jQuery interop much simpler.

from in-view.

+1

from in-view.

I vote for only one DOM node to pass as @vvo mentioned. The utility size should be kept at the minimum.

from in-view.