Giter Club home page Giter Club logo

Comments (5)

mboskamp avatar mboskamp commented on August 27, 2024 1

@joaquinfelici, I added some suggestions to the PRs.
Could you set the correct backport version labels on this issue?

from camunda-bpm-platform.

joaquinfelici avatar joaquinfelici commented on August 27, 2024 1

Hey @mboskamp , I rebased and all jobs are green now, thanks.
And indeed for the labels, just changed them. Please review https://github.com/camunda/camunda-bpm-platform-maintenance/pull/1268.

from camunda-bpm-platform.

joaquinfelici avatar joaquinfelici commented on August 27, 2024

Hints for review

Hey @mboskamp

Fixes:

7.22

  • bumped spring-boot version for parent (used by both run and spring-boot-stater) from 3.3.0 to 3.3.1 (uses tomcat 10.1.25)
  • bumped tomcat version in parent from 9.0.89 to 9.0.90

7.21

  • bumped spring-bootversion for parent (used byspring-boot-starter) from 3.2.6 to 3.2.7 (uses tomcat 10.1.25)
  • bumped spring-boot version for run from 3.3.0 to 3.3.1 (uses tomcat 10.1.25)
  • bumped tomcat version in parent from 9.0.89 to 9.0.90

7.20

  • bumped spring-boot version for run from 3.2.6 to 3.2.7 (uses tomcat 10.1.25)
  • kept old spring-boot version (3.1.12 that uses tomcat 10.1.24) in parent but overrode tomcat version in spring-boot-starter to 10.1.25 for tomcat dependencies
  • bumped tomcat version in parent from 9.0.89 to 9.0.90

7.19

  • bumped tomcat version in parent from 9.0.89 to 9.0.90
  • kept old spring-boot version in parent (2.7.18 that uses tomcat 9.0.83) but:
  • for spring-boot-starter, tomcat dependencies versions are already overridden with this property (see here)
  • same for run (see here)

Note: This may not be 100% ready for merge but this needs to be delivered in next patch so I'd rather you take a look at it while I'm off. Thank you!

from camunda-bpm-platform.

joaquinfelici avatar joaquinfelici commented on August 27, 2024

Hey @mboskamp , I applied your suggestions. The labels for the backport versions were already correctly set for next patch (end of august).

from camunda-bpm-platform.

mboskamp avatar mboskamp commented on August 27, 2024

Hi @joaquinfelici, thanks for implementing the suggestions.

What do you think about the CI failures (Distro EE)? This stage does not fail on the 7.21 and 7.20 branches. Maybe you can solve it by rebasing your PRs.

The version labels have the potential prefix. We are committed to delivering this change with the mentioned versions. In that case, we need the version:x.y.z etc. labels (e.g. version:7.19.15).

from camunda-bpm-platform.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.