Giter Club home page Giter Club logo

Comments (10)

gariah avatar gariah commented on June 10, 2024

Update on this... related products do not appear when you visit a product on its own rather than vis a collection.

For example, if i click a product from the frontpage the URL is : STOREURL/collections/frontpage/products/PRODUCTNAME

The related products appears fine, however if I go to the the same product directly but not in a collection :

STOREURL/products/PRODUCTNAME

The related products are not visible. I believe this may be a bug with the related products snippet?

from shopify-theme-framework.

Cam avatar Cam commented on June 10, 2024

Hi Gariah,

I've seen this issue before in another theme. There must be something wrong with the way it's coded. Can you send me the link/password to view the issue on your store? You can get in touch with me directly at http://cam.vc/#contact

from shopify-theme-framework.

Cam avatar Cam commented on June 10, 2024

I have found the issue. It relates to the way the product loop links to the product pages. Related items don't work when the product page is not accessed within a collection, and the image is linked to the products direct URL (as opposed to the collection URL).

Try clicking the product name on the front page, as opposed to the product image, and you will see what I mean. Suddenly the related items show up!

I'll fix the code for the product loop and commit that as soon as I can. In the meantime, I suggest editing the product loop where the image is wrapped by a link, to reflect the link as it is for the product title.

from shopify-theme-framework.

Cam avatar Cam commented on June 10, 2024

To expand on my comment. Simply change {{ url }} to {{ product.url | within: collection }}.

I am about to commit the fixed files too.

from shopify-theme-framework.

gariah avatar gariah commented on June 10, 2024

Perfect thanks Cam!

Sent from my iPhone

On 30 Oct 2013, at 03:36, Cam [email protected] wrote:

To expand on my comment. Simply change {{ url }} to {{ product.url | within: collection }}.

I am about to commit the fixed files too.


Reply to this email directly or view it on GitHub.

from shopify-theme-framework.

Cam avatar Cam commented on June 10, 2024

No probs ;)

from shopify-theme-framework.

gariah avatar gariah commented on June 10, 2024

Just tried this and it solved the problem for the front page, how could i do it with the view all collections? i.e. collections/all/

from shopify-theme-framework.

Cam avatar Cam commented on June 10, 2024

Unfortunately that's a limitation of Shopify. You can fix it by following the steps at http://docs.shopify.com/support/your-store/collections/taking-control-of-your-catalog-page

from shopify-theme-framework.

gariah avatar gariah commented on June 10, 2024

ohh ok thanks, i'll take a look at that link! I can't wait to show you the site I've built with this.. its looking great! I'm already a Foundation heavyweight but not so much with shopify so this has been an invaluable tool

from shopify-theme-framework.

Cam avatar Cam commented on June 10, 2024

Brilliant! I'm keen to see what you have created :) Thanks for the great feedback. It is very appreciated.

from shopify-theme-framework.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.