Giter Club home page Giter Club logo

Comments (7)

bmalinowsky avatar bmalinowsky commented on June 12, 2024

It will be in the short-term future, there aren't big changes I can think of (probably removal of deprecated code, moving the KNX PB-mode link procedure, etc.).
I will certainly release it before committing the module-infos and other j9 stuff. OTOH v2.3 will stay as-is, and also not receive any updates (unless really serious).

from calimero-core.

lewie avatar lewie commented on June 12, 2024

Thank You @bmalinowsky !

Do I see that correct this fix will only infuse in the 2.4 branch?

Is so, we should use 2.4 master.

from calimero-core.

bmalinowsky avatar bmalinowsky commented on June 12, 2024

Well, the fix is in master now.

For 2.3, I don't know how many users are actually affected by that.
Obviously, the increased resource allocation over time is not nice.
For example: even assuming 2 link creations initially fail per hour (ctor throws, for whatever reason), one can probably run it for a month (48 * 30) even on small platforms before running into memory problems?

from calimero-core.

muenning avatar muenning commented on June 12, 2024

Well, in my case the memory was not the problem but the 8192 thread limit. With OpenHAB 2.x this limit was reached within 12 hours. As this fix seems simple, IMHO backporting it to v2.3 and using that modified (and otherwise static) unofficial version in OH should not be a big deal and generally an one-time effort.

from calimero-core.

bmalinowsky avatar bmalinowsky commented on June 12, 2024

@muenning yes, it's an easy fix. If the openhab devs think it's useful, i can update v2.3, too.

Your numbers indicate that you basically run a busy wait for server connection (?) Edit: Nope, the tunneling connection timeout is actually twice as long (10 s, not 5 s as I thought).

from calimero-core.

muenning avatar muenning commented on June 12, 2024

@bmalinowsky these numbers come from a busy OpenHAB system where the problem starts with dropping and reestablishing connections to a MDT KNX router. The calimero bug may be triggered when the connection slots are exhausted but I think this may be a second bug triggered by another bug. It seems to me that there is a bug in the re-connection handling in OH which could be the trigger. For details you may look at openhab/openhab1-addons#5440.

from calimero-core.

sjsf avatar sjsf commented on June 12, 2024

Just to notice: It's great that the fix for #57 will make it into 2.4, but from my point of view there is no need to create a 2.3 patch nor is this a reason to switch to 2.4-SNAPSHOT immediately - there is an easy workaround by using the other constructor (see e.g. openhab/openhab2-addons#2323)

from calimero-core.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.