Comments (3)
To address the issue where the button content remains visible during loading on the authentication pages, it's essential to focus on how the loading
prop is managed within the Button
component and the handling of the loadingSubmitState
in the form where the button is used. The Button
component is designed to display a loading spinner and disable interaction when the loading
prop is true, which should also hide the button's content. However, if the button content is still visible, it suggests that the conditional rendering based on the loadingSubmitState
might not be functioning as intended or there could be interference from custom styles or other components on the page.
To resolve this, you should:
- Verify the implementation of the
loading
prop in theButton
component to ensure it correctly hides the button content when active. - Check the
loadingSubmitState
variable in the form to confirm it's correctly toggled and passed to theButton
component. - Review any custom CSS or components (such as
Tooltip
,Link
, orIcon
) used on the authentication pages that might affect the visibility of the button content during loading.
If these steps do not resolve the issue, consider examining the AuthContainer
component for any custom loading states that might overlap or interfere with the button's loading state. Adjustments in the handling of the loading
prop, loadingSubmitState
, or custom styles may be necessary to ensure the expected behavior during the loading process.
For specific guidance, refer to the implementation details in the Button.tsx
and related components or styles that might influence the button's behavior during loading.
Details
Sources
- [CAL-2054] UI: We need feedback after clicking buttons
- apps/web/pages/signup.tsx
- packages/ui/components/button/Button.tsx
- packages/app-store/routing-forms/components/FormActions.tsx
- packages/ui/components/button/button.test.tsx
- apps/web/pages/auth/verify.tsx
- apps/web/components/ui/AuthContainer.tsx
About Dosu
This response is meant to be useful and save you time. It is not meant to be a precise solution, but rather a starting point for your own research.
Help me be more useful! Please leave a 👍 if this is helpful and 👎 if it is irrelevant.
To continue the conversation, mention @dosu.
from cal.com.
i would like to work on this issue
from cal.com.
@Anas1005 This is the expected behaviour
from cal.com.
Related Issues (20)
- issue with admin section HOT 1
- verify domain
- [CAL-3872] Get Transcripts from Recording
- [CAL-3873] "Share attendee information" - not toggled, but seats see each other's info HOT 3
- [CAL-3875] Error during org onboarding when migrating a team that has the owner of the org
- [CAL-3877] MEETING URL variable not working in a different language HOT 1
- [CAL-3880] remove i18n for all <Meta> or figure out how to SSR HOT 4
- [CAL-3879] hide app dir banner
- [CAL-3893] Error after build: iframe doesn't exist. `createIframe` must be called before `doInIframe` HOT 1
- Booking limits are being calculated from the attendee's (booker's) perspective (timezone). HOT 1
- [CAL-3897] Assigning managed event types fail when team member has an existing event type with the same slug
- Two hours less time difference in Nextcloud Web HOT 1
- README fails to mention enterprise edition and its license
- [CAL-3898] bug: round robin + offer seats adds all HOT 3
- [CAL-3899] v1 API - add sort option on GET /bookings
- Privacy Link Change HOT 3
- [CAL-3903] set conferencing apps as default
- This bug is not fixed [CAL-2506] Cant post to bookings endpoint - status 500 #11461 HOT 1
- "message": "no_available_users_found_error" HOT 1
- When I put in this payload to book a meeting it books a cal conference instead of a google meet conference. HOT 6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cal.com.