Giter Club home page Giter Club logo

Comments (5)

calavera avatar calavera commented on June 16, 2024

oh, that's weird, the field is here:

#[serde(rename = "SigningCertURL")]

I'm guessing case sensitive issues 🤦

from aws-lambda-events.

ymwjbxxq avatar ymwjbxxq commented on June 16, 2024

It happens.

SigningCertUrl
SigningCertURL

I did not see it as well at first look.

from aws-lambda-events.

ymwjbxxq avatar ymwjbxxq commented on June 16, 2024

On the readme:
We have no desire to manually write event definitions and contributions to that effect will not be accepted. If the [official Go SDK](https://github.com/aws/aws-lambda-go/tree/master/events) is missing an event definition, please file a bug on that project rather than submitting a fix here. Once the official Go SDK has included your changes this project will pick up the new event definitions.

In GO I can see it is correct:
https://github.com/aws/aws-lambda-go/blob/99a9a4bd72b603da8d75d74d77937c146fed0b7c/events/sns.go#L28

I also see that what they call SNSEntity here is called SnsMessage. If it is all generated automatically, I need to find out where the name change is.

Another thing that I see is:
#[serde(rename_all = "PascalCase")]

So, in theory, this SigningCertURL should be SigningCertUrl.

Can you explain to me how to fix it? I think I cannot directly change the aws-lambda-events/aws_lambda_events/src/sns/mod.rs

from aws-lambda-events.

calavera avatar calavera commented on June 16, 2024

Can you explain to me how to fix it? I think I cannot directly change the aws-lambda-events/aws_lambda_events/src/sns/mod.rs

Yes, you can modify that file directly. Only the ones in the generated directory are generated from Go. Make sure you update the test examples too.

from aws-lambda-events.

calavera avatar calavera commented on June 16, 2024

I just released 0.8.2 with the fix. Thank you all.

from aws-lambda-events.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.