Fix installation issues with composer about cakephp-codesniffer HOT 8 CLOSED

This can also be solved by using a custom composer installer that specifies the name of the installation folder explicitly. I alluded to this very problem here: SimplyAdmire/ComposerPlugins#1 but have not yet had time to implement and test the solution.

from cakephp-codesniffer.

Could you not use config option installer-name for this?

2014-05-22 15:30 GMT+02:00 Brian Porter [email protected]:

This can also be solved by using a custom composer installerhttps://getcomposer.org/doc/articles/custom-installers.mdthat specifies the name of the installation folder explicitly. I alluded to
this very problem here: SimplyAdmire/ComposerPlugins#1https://github.com/SimplyAdmire/ComposerPlugins/issues/1but have not yet had time to implement and test the solution.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/74#issuecomment-43887760
.

from cakephp-codesniffer.

This has been somewhat addressed recently in #77

Edited: add link to doc changes: #78

from cakephp-codesniffer.

I think this is solved now. I published a new tag that should show up on composer. If there are installation issues, I'll make more tags 😄

from cakephp-codesniffer.

Yes, using a subfolder to contain the ruleset.xml and the actual sniffs is an excellent pattern to follow-- it solves a lot of problems. But if the goal with a composer installation is to avoid forcing users to remember to run a following --config-set command in order for it to work (which I think is a wise goal), then a custom installer can provide that and make the process as easy as adding the package name to your composer.json file. That seems like the ideal case.

Just like Cake plugins, the Code Standard should direct its own installation. Composer was supposed to free us from these additional configuration steps (like pear's channel-discover) and it exposes the capabilities to do so. We should use them appropriately.

EDIT: Yes yes, I know-- submit a PR.

from cakephp-codesniffer.

I didn't think custom installers were run for anything except the top level composer.json though?

from cakephp-codesniffer.

Wouldn't that be the case if your Cake project's composer.json required cakephp/cakephp-codesniffer though?

from cakephp-codesniffer.

Either way, the proposal to remove the need to run phpcs --config-set should be a new issue now anyway.

from cakephp-codesniffer.