Unit Tests fail, a problem with input parameter 'standard' about cakephp-codesniffer HOT 5 CLOSED

Hi, I'm a bit confused by this issue.

The latest release is 0.1.18 and it does not have any test fails much less a test fail caused by being unable to install the standard. Especially in light of this can you please explain the fundamental error that you're pointing out?

from cakephp-codesniffer.

Yeah, I'm not sure why that is. In fact, just checking out 15d6faa (master) and running the unit tests locally will fail.

It's also not a matter of Travis configuration. The failure is in TestHelper.php; it passes a single string to CodeSniffer for the argument standard. CLI.php chokes at line 732 because it expects an array of strings. That point of failure is way before hitting the first unit test.

This pull and comments alerted me to my failing Travis CI.

I'm not sure why 15d6faa passes Travis CI. It fails for me locally. Would you like me to try to send 15d6faa (my fork of it) to Travis CI and see if it passes?

from cakephp-codesniffer.

This update to PHP_CodeSniffer might have changed what it expects for the argument standard.

Perhaps in catering for applying multiple standards to a check, it now expects array? It could have maintained the ability to accept a single string, rather than an array of a single string, for the sake of backward-compatibility. Maybe we can ask.

But that update to PHP_CodeSniffer was done 8 months ago. (2013-04-01, if you look at the blame for CLI.php.)

Sorry if I messed things up. Just let me know what wires I cut, and I'll take the time to patch things back. OK?

Cheers! :-)

from cakephp-codesniffer.

What version of PHPCS do you have installed. I know that there are problems with our test runner and the 1.5.x release branch. I think the issues with the test suite are related to the new version of PHPCS being released very recently..

from cakephp-codesniffer.

@markstory A brief comparison looks like I have release 1.5.0 (not any of the RCs).

I used the same .travis.xml on my fork. That would install the same version of PHPCS, I think. Will it?

from cakephp-codesniffer.