Execution of Cake script fails if an addin defines an alias that uses nullable reference types in its signature about cake HOT 4 CLOSED

I tried to track down the problem by debugging into Cake.

The issue seems to be in ParameterEmitter.

It writes out all of the method parameter's attributes into the generated Cake script, including System.Runtime.CompilerServices.NullableAttribute.
But the nullable attribute is a little special, since it does not seem to exist in the BCL but instead the C# compiler generates it into the addin assembly as internal class.

This attribute is thus not visible to the generated Cake script, causing the compilation error.

I could see multiple ways to fix this

• Add special handling for the Nullable attribute and simply ignore it when generating the alias method
• Add special handling for the Nullable attribute and emit the proper nullability annotations in the generated script
  • This emits a warning though (usage of nullability annoations when nullable is not enabled)
• Ignore all internal attributes (this might avoid similar problems in the future, but I'm not sure if this causes other issues)

I hope this information is helpful.
I'd be happy in assisting with a bugfix and provide a PR once I know what the fix should look like

from cake.

Ideally the proxy methods generated would have the same signature as the original addin extension method with the exception of the context being supplied.

The warnings could once be pragma disabled and enabled before and after method generation.

from cake.

Ideally the proxy methods generated would have the same signature as the original addin extension method with the exception of the context being supplied.

The warnings could once be pragma disabled and enabled before and after method generation.

Okay, so that would point to special-casing the "Nullable" attribute and emitting a ? in the proper places.
I'll see what I can come up with.

from cake.

🎉 This issue has been resolved in version v4.0.0 🎉

The release is available on:

• GitHub Release
• .NET Tool

Your GitReleaseManager bot 📦🚀

from cake.