Remapping fails on hidden fields about lorenz HOT 4 CLOSED

It will be AbstractClassMappingImpl.complete that is copying the mapping across - though I had thought it wouldn't override existing mappings.

I think that's all that's required here is just tweaking the aforementioned method to check if there is a previously existing mapping (on the plus side performance benefits too?).

cc @Minecrell as he designed the new inheritance system

from lorenz.

This is what happens:

• On requesting the field mapping for the parent, an extra mapping gets added. Now it has f->parentField untyped and f->parentField int
• On completing the child class, the f->parentField int field mapping gets copied over, even though the child already has f->childField untyped
• Requesting the field mapping f int on the child returns parentField

from lorenz.

Oh I see, its an issue of lacking descriptors.

The issue is effecively with this.fields.putIfAbsent(mapping.getSignature(), mapping);, as FieldSignatures are both names and descriptors.

from lorenz.

Alright, I've given this some thought about how to proceed:

• Check for ambiguous cases (where a parent has a typed field of the correct name, but the class has a none-typed field).
• Mark our "synthetic" mappings (where one has been copied by a remapper), and don't copy them

I'm hesitant to act too swiftly here, as I'm concerned that any solution could have a knock-on effect and cause false-positive cases that should have been copied over - there are pros and cons of both above solutions (checking for ambiguous cases is probably the best bet though).

Though, in the mean time there is a solution - field type providers which can ensure that data is filled into the mappings during reading.

from lorenz.