Markdown: 500 for YAML metadata about caddy HOT 5 CLOSED

(Known issue - the line number in the panic message is +2 the actual, so line 64 is actual source of panic. Still not sure why the line number is off.)

I thought I fixed this with commit 8ea98f8 - have you pulled the latest recently? (go get -u github.com/mholt/caddy should do it)

from caddy.

Unfortunately, I get the described effect with the latest HEAD ...

I added debug statements to the load method (metadata.go) ...

func (m *Metadata) load(parsedMap map[string]interface{}) {
    fmt.Printf("-- %v\n", parsedMap)
    if template, ok := parsedMap["title"]; ok {
        m.Title, _ = template.(string)
    }
    if template, ok := parsedMap["template"]; ok {
        m.Template, _ = template.(string)
    }
    if variables, ok := parsedMap["variables"]; ok {
        fmt.Printf("-- %v\n", reflect.TypeOf(variables))
        vars, ok := variables.(map[string]interface{})
        m.Variables = vars
        fmt.Printf("-- %v - %v\n", vars, ok)
    }
}

... and get the following output:

(YAML)

-- map[template:default variables:[map[title:Test]]]
-- []interface {}
-- map[] - false

(TOML)

-- map[template:default variables:map[title:Test]]
-- map[string]interface {}
-- map[title:Test] - true

yaml.Unmarshal (in Parse of YAMLMetadataParser) seems to return something unexpected.

I might have some more time tomorrow for more debugging.

from caddy.

Thanks for testing this out.

I have seen the issue, the fix should be out soon.

Firstly, the YAML syntax used for variables - is for a list and not an object. Only indentation is the requirement for a nested objected. (I am also guilty of this).

Should be

 ---
  template: default
  variables:
    title: Test
  ---

Secondly, the yaml package decodes nested maps into a map[interface{}]interface{} and I was assuming a map[string]interface{}.

Thanks.

from caddy.

@mschoebel The fix has been merged. Let us know if it works now.

Thanks.

from caddy.

Works. 👍

YAML is weird.

from caddy.