[DRAFT] Consider adding a API about ads HOT 6 CLOSED

Another possibility is to do all of the stats externally, to keep this plugin as light as possible. For example, one could use the dnstap plugin to log these requests, and then build a stats dashboard based on the real-time dnstap data.

from ads.

First of all: Thanks for your suggestion!

Getting rid of the stats thing is probably a good idea. Thats why i have removed the code I already wrote in the master branch.
I will still consider some way to dynamically configure Block rules, however I am not sure how at the moment.

from ads.

It's not a bad idea, but not sure if its worth the effort. Pretty common is an exporter for Prometheus, writte like https://prometheus.io/docs/instrumenting/writing_exporters/ and also available for coredns itself https://github.com/coredns/coredns/tree/master/plugin/metrics

from ads.

Prometheus is great for simple metrics, like counting how many lookups were blocked vs allowed, but it doesn't do well with high-cardinality metrics, like tracking how many times each specific blocked domain has had a lookup blocked, or what are the top blocked domains. Though perhaps richer stats like that aren't sufficiently interesting to bother with.

from ads.

At this point I want to note that the plugin already exposes (at least it should) some metrics through prometheus:
https://github.com/c-mueller/ads/blob/master/metrics.go

from ads.

Because I think that the prometheus stats expose enough information. I will not further consider the implementation of this part of the api.

Regarding the dynamic configuration of rules I think going the same route as the hosts plugin is the best solution. This means that Rules can be dynamically configured through a external file. where the path gets defined in the Corefile. This file gets reloaded in a certan interval (or maybe through filesystem hooks).

I will open a new issue for this. This one is closed!

from ads.